Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#392: Make pylint errors cause a CI failure #395

Merged
merged 4 commits into from
Jun 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lbaf/Execution/lbsBruteForceAlgorithm.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def compute_arrangement_works(self, objects: tuple, arrangement: tuple) -> dict:
values["sent volume"] = v

# Aggregate and store work for this rank
works[rank] = self.work_model.aggregate(values)
works[rank] = self._work_model.aggregate(values)

# Return arrangement works
return works
Expand All @@ -75,7 +75,7 @@ def execute(self, p_id: int, phases: list, distributions: dict, statistics: dict
objects = []

# Iterate over ranks
phase_ranks = phase.get_ranks()
phase_ranks = phases.get_ranks()
for rank in phase_ranks:
for o in rank.get_objects():
entry = {
Expand Down
1 change: 1 addition & 0 deletions src/lbaf/Execution/lbsRecursiveTransferStrategy.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from ..Model.lbsPhase import Phase
from ..Utils.exception_handler import exc_handler
from ..IO.lbsStatistics import inverse_transform_sample
from ..Model.lbsObjectCommunicator import ObjectCommunicator

class RecursiveTransferStrategy(TransferStrategyBase):
"""A concrete class for the recursive transfer strategy."""
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ allowlist_externals =
alwayscopy = true
download = true
recreate = true
ignore_errors=true
ignore_outcome=true
ignore_errors=false
ignore_outcome=false
commands =
bash -c 'mkdir -p artifacts; pylint --rcfile=.pylintrc --output-format=text,text:artifacts/pylint.txt src'

Expand Down