Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#263: two modes or erroring out in lbaf #271

Merged
merged 6 commits into from
Jun 28, 2022
Merged

#263: two modes or erroring out in lbaf #271

merged 6 commits into from
Jun 28, 2022

Conversation

marcinwrobel1986
Copy link
Contributor

THIS PR:

  • added exception handler to utils
  • applied exception handler policy to all known error cases

Closes #263

Marcin Wróbel added 2 commits June 23, 2022 17:26
#263: - added exception handler to utils
427e7cc 
- applied exception handler policy to all known error cases
#263: - merged 261-add-CI-action-to-step-dataset
04e5a92
@marcinwrobel1986 marcinwrobel1986 added the bug Something isn't working label Jun 23, 2022
@marcinwrobel1986 marcinwrobel1986 requested a review from ppebay June 23, 2022 15:33
@marcinwrobel1986 marcinwrobel1986 self-assigned this Jun 23, 2022
ppebay
ppebay requested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@ppebay ppebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for the most part, just a handful of changes

src/lbaf/Applications/conf.yaml Show resolved Hide resolved
src/lbaf/IO/lbsVTDataReader.py Outdated Show resolved Hide resolved
src/lbaf/Utils/JSON_data_files_validator.py Outdated Show resolved Hide resolved
src/lbaf/Utils/data_stat_files_updater.py Outdated Show resolved Hide resolved
src/lbaf/Utils/csv_2_json_data_converter.py Outdated Show resolved Hide resolved
src/lbaf/Utils/csv_2_json_data_converter.py Outdated Show resolved Hide resolved
@ppebay ppebay merged commit fee97e6 into develop Jun 28, 2022
@ppebay ppebay deleted the 263-two-modes-or-erroring-out-in-LBAF branch June 28, 2022 11:46
@nmm0 nmm0 mentioned this pull request Jun 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppebay ppebay ppebay approved these changes

Assignees

@marcinwrobel1986 marcinwrobel1986

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 modes or erroring-out in LBAF
2 participants
@marcinwrobel1986 @ppebay