Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix INPUT_MODULE ordering #551

Closed
cwschilly opened this issue Sep 28, 2024 · 0 comments · Fixed by #552
Closed

Fix INPUT_MODULE ordering #551

cwschilly opened this issue Sep 28, 2024 · 0 comments · Fixed by #552

Comments

@cwschilly
Copy link
Contributor

We get this error on the deploy docs pipeline:

Traceback (most recent call last):
  File "python.py", line 3208, in <module>
    run(os.path.dirname(os.path.abspath(args.conf)), config, templates=os.path.abspath(args.templates))
  File "python.py", line 2986, in run
    modules_to_crawl += crawl_module(state, path, object)
  File "python.py", line 653, in crawl_module
    assert parent_path_str in state.name_map, "%s listed in INPUT_MODULES without %s being known yet, add the parent explicitly earlier" % ('.'.join(path), parent_path_str)
AssertionError: lbaf.Model.lbsAffineCombinationWorkModel listed in INPUT_MODULES without lbaf.Model being known yet, add the parent explicitly earlier

We should also try to find a way to get these errors to show up on the PR instead of waiting until we merge to uncover them (since the deploy_docs pipeline only completes on pushes to develop or main).

@cwschilly cwschilly linked a pull request Sep 28, 2024 that will close this issue
cwschilly added a commit that referenced this issue Sep 28, 2024
cwschilly added a commit that referenced this issue Sep 28, 2024
cwschilly added a commit that referenced this issue Sep 30, 2024
cwschilly added a commit that referenced this issue Sep 30, 2024
cwschilly added a commit that referenced this issue Sep 30, 2024
cwschilly added a commit that referenced this issue Sep 30, 2024
cwschilly added a commit that referenced this issue Sep 30, 2024
* #551: build documentation on any branch; only deploy on develop or main

* #551: reorder input modules

* #551: try including root modules

* #551: interrogate docs build process

* #551: specify parent modules

* #551: remove debug prints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant