Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a way to optionally start subclustering after all ranks have stopped swapping #486

Closed
ppebay opened this issue Dec 21, 2023 · 0 comments · Fixed by #488
Closed
Assignees
Labels
enhancement New feature or request

Comments

@ppebay
Copy link
Contributor

ppebay commented Dec 21, 2023

Currently the cluster swapping strategy (in non-deterministic mode) jumps into subclustering as soon as no full cluster swaps are possible on a given rank, irrespective of swapping/non-swapping on other ranks.

This has the effect of improving load balance locally but at the expense of earlier memory locality disruption than as compared to when subclustering is delayed until all ranks have exhausted full cluster swapping possibilities.

This is in contrast to the implementation of temperedlb in vt, which has some global fence between cluster swaps and the subclustering stage.

The goal of this issue is to allow for the latter (vt-like) option in LBAF as well.

@lifflander

@ppebay ppebay added the enhancement New feature or request label Dec 21, 2023
@ppebay ppebay self-assigned this Dec 21, 2023
ppebay added a commit that referenced this issue Dec 22, 2023
ppebay added a commit that referenced this issue Dec 22, 2023
cwschilly added a commit that referenced this issue Jan 4, 2024
ppebay added a commit that referenced this issue Jan 10, 2024
…ks have stopped swapping (#488)

* #486: fully separated swapping from subclustering and made other improvements

* #486: fixed whitespace cleanup

* #486: fixed a bug related to average load and removed intermediate variable

* #486: completed optional separation of swapping and subclustering governed by an optional parameter

* #486: fix subclustering test to reflect changes

* #486: add unit test for new separate_subclustering param

* #486: add missing config file

---------

Co-authored-by: Caleb Schilly <[email protected]>
github-actions bot pushed a commit that referenced this issue Jan 10, 2024
…ks have stopped swapping (#488)

* #486: fully separated swapping from subclustering and made other improvements

* #486: fixed whitespace cleanup

* #486: fixed a bug related to average load and removed intermediate variable

* #486: completed optional separation of swapping and subclustering governed by an optional parameter

* #486: fix subclustering test to reflect changes

* #486: add unit test for new separate_subclustering param

* #486: add missing config file

---------

Co-authored-by: Caleb Schilly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant