Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify/Update the online documentation #393

Closed
cwschilly opened this issue May 31, 2023 · 5 comments · Fixed by #399
Closed

Verify/Update the online documentation #393

cwschilly opened this issue May 31, 2023 · 5 comments · Fixed by #399
Assignees

Comments

@cwschilly
Copy link
Contributor

cwschilly commented May 31, 2023

Related to #376

@cwschilly cwschilly self-assigned this May 31, 2023
@cwschilly
Copy link
Contributor Author

Running JSON_data_files_validator_loader and vt_data_extractor.py from the command line leads to errors. Are these still intended to be used independently by users, or are they meant to be interacted with indirectly elsewhere in the code base? (For example, running test_JSON_data_files_validator.py calls the validator loader and works perfectly)

@tlamonthezie
Copy link
Contributor

tlamonthezie commented Jun 5, 2023

Running JSON_data_files_validator_loader and vt_data_extractor.py from the command line leads to errors. Are these still intended to be used independently by users, or are they meant to be interacted with indirectly elsewhere in the code base? (For example, running test_JSON_data_files_validator.py calls the validator loader and works perfectly)

JSON_data_files_validator_loader cannot be currently run alone (it is called internally by the LBAF application) but it could be made runnable easily with the addition of a main function and by using absolute imports to the lbaf package. We have to create an issue for that. Thank you @cwschilly for the newly created issue #396

@cwschilly
Copy link
Contributor Author

I still need to update the wiki and README after resolution of #396 and #397

@stmcgovern
Copy link

After discussion, this issue concerns only the content of the documentation and the modifications to deploy docs workflow have been split off into issue #419 .

@cwschilly
Copy link
Contributor Author

@ppebay This issue can be closed with #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants