Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor distributed information stage #323

Closed
ppebay opened this issue Dec 9, 2022 · 0 comments · Fixed by #390
Closed

Refactor distributed information stage #323

ppebay opened this issue Dec 9, 2022 · 0 comments · Fixed by #390
Assignees
@ppebay
Labels
enhancement New feature or request

Comments

@ppebay
Copy link
Contributor

ppebay commented Dec 9, 2022 •
edited
Loading

This issue is motivated by that fact that, over time, implicit assumptions have crept in regarding what's know/unknown by the sender regarding the destination rank.

The information stage must be refactored to be fully distributed again (as it was when load-only information was contained)
@ppebay ppebay added the enhancement New feature or request label Dec 9, 2022
@ppebay ppebay self-assigned this Dec 9, 2022
@ppebay ppebay mentioned this issue May 27, 2023
Closed
@ppebay ppebay changed the title Refactor information stage to cleanly separate out information that is gossiped Refactor distributed information stage May 27, 2023
ppebay added a commit that referenced this issue May 28, 2023
@ppebay
#323: moved all messaging logic to inform and transfer algo
12f7c6e
@ppebay ppebay mentioned this issue May 28, 2023
Merged
ppebay added a commit that referenced this issue May 28, 2023
@ppebay
#323: separated out load information
ed941f4
ppebay added a commit that referenced this issue May 29, 2023
@ppebay
#323: simplified code by makings "targets" a set instead of dict
f9b7c37
ppebay added a commit that referenced this issue May 30, 2023
@ppebay
#323: added "estimate" method to criteria for non-local information (…
2cf2776 
…distributed)
cwschilly added a commit that referenced this issue May 30, 2023
@cwschilly
#323: Fix whitespace error
057d992
cwschilly added a commit that referenced this issue May 30, 2023
@cwschilly
#323: Update tests to reflect changes in Rank
1f60c02
cwschilly added a commit that referenced this issue Jun 1, 2023
@cwschilly
#323: create test for InformAndTransferAlgorithm
c500516
@nmm0 nmm0 mentioned this issue Jun 6, 2023
Open
ppebay added a commit that referenced this issue Jun 10, 2023
@ppebay
#323: progress update (refactored messages now processed and relayed)
f896fb8
ppebay added a commit that referenced this issue Jun 10, 2023
@ppebay
#323: fixed debug statement
02e4a8c
ppebay added a commit that referenced this issue Jun 11, 2023
@ppebay
#323: fixed initial spawning and aggregation of initial messages
3e78ffc
ppebay added a commit that referenced this issue Jun 11, 2023
@ppebay
#323: completed refactoring of information stage
fdf14e5
ppebay added a commit that referenced this issue Jun 11, 2023
@ppebay
#323: made transfer algorithms work again with refactored information
ea555fe
ppebay added a commit that referenced this issue Jun 11, 2023
@ppebay
#323: fixed test errors
e0aa9ff
ppebay added a commit that referenced this issue Jun 11, 2023
@ppebay
#323: removed useless header comments
0e1a92a
ppebay added a commit that referenced this issue Jun 11, 2023
@ppebay
#323: displaced CMF calculation where it belongs
a37415c
cwschilly added a commit that referenced this issue Jun 13, 2023
@cwschilly
#323: fix unit tests to reflect changes in lbsMessage and lbsRank
0d259c4
cwschilly added a commit that referenced this issue Jun 14, 2023
@cwschilly
#323: finalize InformAndTransfer testing and fix typos in Rank
24bd3cc
cwschilly added a commit that referenced this issue Jun 15, 2023
@cwschilly
#323: add work to r_qoi_list
74863a0
cwschilly added a commit that referenced this issue Jun 15, 2023
@cwschilly
#388: print list of implemented qois (#405)
0a097b0 
* #388: Add verbosity level argument to lbaf.app (in progress)

* #388: add command line option to print list of implemented QOI

* #388: add default verbosity level

* #388: print all possible QOI

* #388: move verbosity argument within printing function

* #388: alter formatting of output

* #388: simplify for loop

* #388: update --help message, fix typo

* #388: more formatting changes to output list

* #388: print list as part of error for invalid QOI

* #323: add work to r_qoi_list
github-actions bot pushed a commit that referenced this issue Jun 15, 2023
@cwschilly
#388: print list of implemented qois (#405)
1435725 
* #388: Add verbosity level argument to lbaf.app (in progress)

* #388: add command line option to print list of implemented QOI

* #388: add default verbosity level

* #388: print all possible QOI

* #388: move verbosity argument within printing function

* #388: alter formatting of output

* #388: simplify for loop

* #388: update --help message, fix typo

* #388: more formatting changes to output list

* #388: print list as part of error for invalid QOI

* #323: add work to r_qoi_list
ppebay added a commit that referenced this issue Jul 8, 2023
@ppebay @cwschilly
#323: Refactor distributed information stage (#390)
df02bb2 
* #323: moved all messaging logic to inform and transfer algo

* #323: separated out load information

* #323: simplified code by makings "targets" a set instead of dict

* #323: added "estimate" method to criteria for non-local information (distributed)

* #323: Fix whitespace error

* #323: Update tests to reflect changes in Rank

* #323: create test for InformAndTransferAlgorithm

* #323: progress update (refactored messages now processed and relayed)

* #323: fixed debug statement

* #323: fixed initial spawning and aggregation of initial messages

* #323: completed refactoring of information stage

* #323: made transfer algorithms work again with refactored information

* #323: fixed test errors

* #323: removed useless header comments

* #323: displaced CMF calculation where it belongs

* #323: fix unit tests to reflect changes in lbsMessage and lbsRank

* #323: finalize InformAndTransfer testing and  fix typos in Rank

---------

Co-authored-by: Caleb Schilly <[email protected]>
@ppebay ppebay mentioned this issue Jul 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppebay ppebay

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#323: Refactor distributed information stage DARMA-tasking/LB-analysis-framework
1 participant
@ppebay