Skip to content

#501: add option to sort clusters #766

#501: add option to sort clusters

#501: add option to sort clusters #766

Status Failure
Total duration 5m 26s
Artifacts

code-quality.yml

on: push
Matrix: code-quality
Fit to window
Zoom out
Zoom in

Annotations

8 errors, 12 warnings, and 10 notices
code-quality (ubuntu-latest, 3.9)
Process completed with exit code 1.
tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20240228175113 ► tests.unit.IO.test_lbs_vt_data_reader.TestConfig ► test_lbs_vt_data_reader_read_wrong_schema: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20240228175113.xml#L1
Failed test found in: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20240228175113.xml Error: Traceback (most recent call last):
code-quality (ubuntu-latest, 3.9)
Failed tests were found and 'fail-on-error' option is set to true
tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20240228175108 ► tests.unit.IO.test_lbs_vt_data_reader.TestConfig ► test_lbs_vt_data_reader_read_wrong_schema: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20240228175108.xml#L1
Failed test found in: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20240228175108.xml Error: Traceback (most recent call last):
code-quality (ubuntu-latest, 3.8)
Failed tests were found and 'fail-on-error' option is set to true
code-quality (ubuntu-latest, 3.8)
Process completed with exit code 255.
code-quality (ubuntu-latest, 3.9)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, phoenix-actions/test-reporting@v12. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
code-quality (ubuntu-latest, 3.8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, phoenix-actions/test-reporting@v12. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
code-quality (ubuntu-latest, 3.8): src/lbaf/Utils/lbsJSONDataFilesValidatorLoader.py#L10
Unused PROJECT_PATH imported from lbaf (unused-import)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsWorkStealingAlgorithm.py#L163
TODO: are we double counting steal time here? (see line 99) (fixme)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsWorkStealingAlgorithm.py#L170
TODO: need to yield here -- but for how long? (fixme)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsWorkStealingAlgorithm.py#L223
Unused variable 'num_steal_reqs' (unused-variable)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsWorkStealingAlgorithm.py#L262
Unused private member `WorkStealingAlgorithm.__discretion_interval` (unused-private-member)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsWorkStealingAlgorithm.py#L284
Unused private member `WorkStealingAlgorithm.__experiment_times` (unused-private-member)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsWorkStealingAlgorithm.py#L322
Attribute 'memory_intensive_clusters' defined outside __init__ (attribute-defined-outside-init)
code-quality (ubuntu-latest, 3.8): src/lbaf/Utils/lbsDataStatFilesUpdater.py#L18
Too few public methods (1/2) (too-few-public-methods)
code-quality (ubuntu-latest, 3.8): src/lbaf/Utils/lbsJSONDataFilesValidatorLoader.py#L1
Missing module docstring (missing-module-docstring)
code-quality (ubuntu-latest, 3.8): src/lbaf/Utils/lbsJSONDataFilesValidatorLoader.py#L66
Method could be a function (no-self-use)
code-quality (ubuntu-latest, 3.8): src/lbaf/Utils/lbsArgumentParser.py#L18
Too many arguments (14/7) (too-many-arguments)
code-quality (ubuntu-latest, 3.8): src/lbaf/Utils/lbsArgumentParser.py#L36
Consider using Python 3 style super() without arguments (super-with-arguments)
code-quality (ubuntu-latest, 3.8): src/lbaf/Utils/lbsArgumentParser.py#L82
Consider merging these comparisons with "in" to "raw_response in ('', 'None')" (consider-using-in)
code-quality (ubuntu-latest, 3.8): src/lbaf/Utils/lbsArgumentParser.py#L58
Too many branches (17/12) (too-many-branches)
code-quality (ubuntu-latest, 3.8): src/lbaf/Utils/lbsArgumentParser.py#L58
Method could be a function (no-self-use)
code-quality (ubuntu-latest, 3.8): src/lbaf/Utils/lbsArgumentParser.py#L149
Unnecessary "else" after "return" (no-else-return)
code-quality (ubuntu-latest, 3.8): src/lbaf/Utils/lbsArgumentParser.py#L165
Unnecessary "else" after "return" (no-else-return)