Code Quality (Tests, Linting, Coverage)

#446: fixed debug hack use to prevent division by zero error when ski… #640

Sign in to view logs

Triggered via push October 25, 2023 15:09

cwschilly

446-resolve-with-subclustering-improvements

Status Success

Total duration 4m 15s

Artifacts 2

This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

code-quality.yml

on: push

Matrix: code-quality

Annotations

12 warnings and 10 notices

code-quality (ubuntu-latest, 3.9)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, phoenix-actions/test-reporting@v12. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

code-quality (ubuntu-latest, 3.8)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, phoenix-actions/test-reporting@v12, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsTemperedCriterion.py#L8

Method 'estimate' is abstract in class 'CriterionBase' but is not overridden (abstract-method)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsClusteringTransferStrategy.py#L62

Unused variable 'i' (unused-variable)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsClusteringTransferStrategy.py#L91

Parameter 'phase' has been renamed to 'known_peers' in overridden 'ClusteringTransferStrategy.execute' method (arguments-renamed)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsClusteringTransferStrategy.py#L91

Parameter 'known_peers' has been renamed to 'phase' in overridden 'ClusteringTransferStrategy.execute' method (arguments-renamed)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsCentralizedPrefixOptimizerAlgorithm.py#L152

Lambda may not be necessary (unnecessary-lambda)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsRecursiveTransferStrategy.py#L63

Parameter 'phase' has been renamed to 'known_peers' in overridden 'RecursiveTransferStrategy.execute' method (arguments-renamed)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsRecursiveTransferStrategy.py#L63

Parameter 'known_peers' has been renamed to 'phase' in overridden 'RecursiveTransferStrategy.execute' method (arguments-renamed)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsAlgorithmBase.py#L100

Unreachable code (unreachable)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsAlgorithmBase.py#L251

Unnecessary pass statement (unnecessary-pass)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsCriterionBase.py#L66

Dangerous default value [] as argument (dangerous-default-value)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsRuntime.py#L1

Missing module docstring (missing-module-docstring)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsRuntime.py#L11

Too many arguments (8/7) (too-many-arguments)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsRuntime.py#L105

Variable name "pp" doesn't conform to snake_case naming style (invalid-name)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsTemperedCriterion.py#L1

Missing module docstring (missing-module-docstring)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsInformAndTransferAlgorithm.py#L1

Missing module docstring (missing-module-docstring)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsInformAndTransferAlgorithm.py#L31

Consider using Python 3 style super() without arguments (super-with-arguments)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsInformAndTransferAlgorithm.py#L81

Argument name "m" doesn't conform to snake_case naming style (invalid-name)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsInformAndTransferAlgorithm.py#L90

Argument name "f" doesn't conform to snake_case naming style (invalid-name)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsInformAndTransferAlgorithm.py#L106

Too many local variables (18/15) (too-many-locals)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsInformAndTransferAlgorithm.py#L135

Variable name "m" doesn't conform to snake_case naming style (invalid-name)

Artifacts

Produced during runtime

Name	Size
coverage Expired	5.95 KB
pylint Expired	38.2 KB