Skip to content
Code Quality (Tests, Linting, Coverage)

#464: optimize transfer swapping logic and improve instrumentation … … #610

Sign in to view logs

#464: optimize transfer swapping logic and improve instrumentation … …

#464: optimize transfer swapping logic and improve instrumentation … … #610

Triggered via push October 16, 2023 17:15
@cwschillycwschilly
pushed 8682f91
develop
Status Success
Total duration 4m 30s
Artifacts 2
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

code-quality.yml

on: push
Matrix: code-quality
Fit to window
Zoom out
Zoom in

Annotations

10 warnings and 10 notices
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsCentralizedPrefixOptimizerAlgorithm.py#L152
Lambda may not be necessary (unnecessary-lambda)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsCriterionBase.py#L66
Dangerous default value [] as argument (dangerous-default-value)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsCriterionBase.py#L76
Unnecessary pass statement (unnecessary-pass)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsCriterionBase.py#L79
Dangerous default value [] as argument (dangerous-default-value)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsClusteringTransferStrategy.py#L92
Parameter 'phase' has been renamed to 'known_peers' in overridden 'ClusteringTransferStrategy.execute' method (arguments-renamed)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsClusteringTransferStrategy.py#L92
Parameter 'known_peers' has been renamed to 'phase' in overridden 'ClusteringTransferStrategy.execute' method (arguments-renamed)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsClusteringTransferStrategy.py#L172
Redeclared variable 'r_dst' in assignment (redeclared-assigned-name)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsRecursiveTransferStrategy.py#L63
Parameter 'phase' has been renamed to 'known_peers' in overridden 'RecursiveTransferStrategy.execute' method (arguments-renamed)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsRecursiveTransferStrategy.py#L63
Parameter 'known_peers' has been renamed to 'phase' in overridden 'RecursiveTransferStrategy.execute' method (arguments-renamed)
code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsAlgorithmBase.py#L100
Unreachable code (unreachable)
code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsVTDataWriter.py#L1
Missing module docstring (missing-module-docstring)
code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsVTDataWriter.py#L50
Method could be a function (no-self-use)
code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsVTDataWriter.py#L113
Use a generator instead 'all(isinstance(p, Phase) for p in phases.values())' (use-a-generator)
code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsVTDataWriter.py#L121
Variable name "p" doesn't conform to snake_case naming style (invalid-name)
code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsVTDataWriter.py#L122
Variable name "r" doesn't conform to snake_case naming style (invalid-name)
code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsVTDataWriter.py#L12
Too few public methods (1/2) (too-few-public-methods)
code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsConfigurationValidator.py#L56
Use a generator instead 'all(isinstance(y, float) for y in x.values())' (use-a-generator)
code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsConfigurationValidator.py#L100
Use a generator instead 'all(isinstance(y, int) for y in x)' (use-a-generator)
code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsConfigurationValidator.py#L203
Unnecessary "else" after "return" (no-else-return)
code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsConfigurationValidator.py#L212
Too many branches (13/12) (too-many-branches)

Artifacts

Produced during runtime
Name Size
coverage Expired
5.95 KB
pylint Expired
38.7 KB