Code Quality (Tests, Linting, Coverage)

Revert "Merge branch 'develop' into 558-add-node-level-memory-constra… #1196

Triggered via push December 30, 2024 18:28

ppebay

pushed 737e2a5

558-add-node-level-memory-constraint

Status Failure

Total duration 5m 14s

Artifacts –

code-quality.yml

on: push

Matrix: code-quality

Annotations

17 errors, 14 warnings, and 10 notices

code-quality (ubuntu-latest, 3.11)

Process completed with exit code 1.

tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182902 ► tests.unit.IO.test_lbs_vt_data_reader.TestConfig ► test_lbs_vt_data_reader_populate_rank: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182902.xml#L1

Failed test found in: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182902.xml Error: TypeError: LoadReader._populate_rank() missing 1 required positional argument: 'nodes'

tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182902 ► tests.unit.IO.test_lbs_vt_data_reader.TestConfig ► test_lbs_vt_data_reader_read_compressed: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182902.xml#L1

code-quality (ubuntu-latest, 3.11)

Failed tests were found and 'fail-on-error' option is set to true

code-quality (ubuntu-latest, 3.10)

Process completed with exit code 1.

tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182859 ► tests.unit.IO.test_lbs_vt_data_reader.TestConfig ► test_lbs_vt_data_reader_populate_rank: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182859.xml#L1

Failed test found in: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182859.xml Error: TypeError: LoadReader._populate_rank() missing 1 required positional argument: 'nodes'

tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182859 ► tests.unit.IO.test_lbs_vt_data_reader.TestConfig ► test_lbs_vt_data_reader_read_compressed: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182859.xml#L1

code-quality (ubuntu-latest, 3.10)

Failed tests were found and 'fail-on-error' option is set to true

code-quality (ubuntu-latest, 3.9)

Process completed with exit code 1.

tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182901 ► tests.unit.IO.test_lbs_vt_data_reader.TestConfig ► test_lbs_vt_data_reader_populate_rank: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182901.xml#L1

Failed test found in: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182901.xml Error: TypeError: _populate_rank() missing 1 required positional argument: 'nodes'

tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182901 ► tests.unit.IO.test_lbs_vt_data_reader.TestConfig ► test_lbs_vt_data_reader_read_compressed: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182901.xml#L1

code-quality (ubuntu-latest, 3.9)

Failed tests were found and 'fail-on-error' option is set to true

tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182908 ► tests.unit.IO.test_lbs_vt_data_reader.TestConfig ► test_lbs_vt_data_reader_populate_rank: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182908.xml#L1

Failed test found in: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182908.xml Error: TypeError: _populate_rank() missing 1 required positional argument: 'nodes'

tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182908 ► tests.unit.IO.test_lbs_vt_data_reader.TestConfig ► test_lbs_vt_data_reader_read_compressed: artifacts/unittest/reports/TEST-tests.unit.IO.test_lbs_vt_data_reader.TestConfig-20241230182908.xml#L1

code-quality (ubuntu-latest, 3.8)

Failed tests were found and 'fail-on-error' option is set to true

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsClusteringTransferStrategy.py#L211

Possibly using variable 'r_dst' before assignment (possibly-used-before-assignment)

code-quality (ubuntu-latest, 3.8)

Process completed with exit code 255.

code-quality (ubuntu-latest, 3.11)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

code-quality (ubuntu-latest, 3.10)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

code-quality (ubuntu-latest, 3.9)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

code-quality (ubuntu-latest, 3.8)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

code-quality (ubuntu-latest, 3.8): src/lbaf/Model/lbsNode.py#L63

Unused private member `Node.__index` (unused-private-member)

code-quality (ubuntu-latest, 3.8): src/lbaf/Model/lbsNode.py#L44

Unused import copy (unused-import)

code-quality (ubuntu-latest, 3.8): src/lbaf/Model/lbsNode.py#L45

Unused import math (unused-import)

code-quality (ubuntu-latest, 3.8): src/lbaf/Model/lbsNode.py#L49

Unused Optional imported from typing (unused-import)

code-quality (ubuntu-latest, 3.8): src/lbaf/Model/lbsRank.py#L92

Dangerous default value [] as argument (dangerous-default-value)

code-quality (ubuntu-latest, 3.8): src/lbaf/Model/lbsQOIDecorator.py#L44

Unused argument 'args' (unused-argument)

code-quality (ubuntu-latest, 3.8): src/lbaf/Model/lbsQOIDecorator.py#L44

Unused argument 'kwargs' (unused-argument)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsClusteringTransferStrategy.py#L306

Unused private member `ClusteringTransferStrategy.__transfer_subclusters(self, phase: Phase, r_src: Rank, targets: set, ave_load: float, max_load: float)` (unused-private-member)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsTemperedCriterion.py#L50

Method 'estimate' is abstract in class 'CriterionBase' but is not overridden in child class 'TemperedCriterion' (abstract-method)

code-quality (ubuntu-latest, 3.8): src/lbaf/Execution/lbsAlgorithmBase.py#L96

Lambda may not be necessary (unnecessary-lambda)

code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsVTDataReader.py#L79

Line too long (133/120) (line-too-long)

code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsVTDataReader.py#L59

Too many instance attributes (10/7) (too-many-instance-attributes)

code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsVTDataReader.py#L205

Too many local variables (40/15) (too-many-locals)

code-quality (ubuntu-latest, 3.8): src/lbaf/IO/lbsVTDataReader.py#L205

Too many branches (19/12) (too-many-branches)