-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a11y testing #2946
base: main
Are you sure you want to change the base?
Add a11y testing #2946
Conversation
efde603
to
9d79457
Compare
We're going to take a manual testing approach for now. |
let's keep this open for one more day - want to try something with this as a base |
@xmunoz had a sec to take a pass at this and here's the output - the sorry for some of the gemfile regressions. I think probably drop and redo the merge commit there. |
Sweet, thanks! |
943e881
to
1545265
Compare
One of the a11y violations was fixed by upgrading |
Add test helper for a11y check
This should remove the role attribute from the default bootstrap form https://github.com/bootstrap-ruby/bootstrap_form#configuration
Fixes #1691 .