Complete and validate #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** | ||
| * Verifies if a bag is complete. | ||
| * According to the BagIt v16 specs, a bag is complete when: |
There was a problem hiding this comment.
use spelled out "version 16" for the release "versions" and "V1.0", "V0.97" for main versions.
| /** | ||
| * Verifies if a bag is complete. | ||
| * According to the BagIt v16 specs, a bag is complete when: | ||
| * <ul> |
There was a problem hiding this comment.
Use Scaladoc "markdown" (?)
There was a problem hiding this comment.
can't find it. you got a reference?
| (bag / "bagit.txt").toJava should exist | ||
| bag.data.toJava should exist | ||
| bag.glob("manifest-*.txt").toList should not be empty | ||
| bag.fetchFiles shouldBe empty |
There was a problem hiding this comment.
Do you need to check first if your test data is correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
Implements
isCompleteisValid...according to the BagIt specs. Both methods return
Either[String, Unit], meaning that if the bag is complete/valid, it returnsRight[Unit]and if the bag is not complete/valid, it returnsLeft[String], with theStringcontaining the message why the bag is not complete/valid.@janvanmansum @lindareijnhoudt @jo-pol for review