Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fixes because other packages break other packages #1233

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Nov 17, 2024

Fixes for CI.

Contains 1 temporary fix around plotly.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz skrawcz marked this pull request as ready for review November 18, 2024 02:09
@skrawcz skrawcz changed the title testing CI from fresh branch CI fixes because other packages break other packages Nov 18, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to afd93d3 in 42 seconds

More details
  • Looked at 61 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .ci/test.sh:31
  • Draft comment:
    Consider using a more explicit version check for clarity:
    if python -c 'import sys; exit(0) if sys.version_info >= (3, 9) else exit(1)'; then
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds a version check for Python 3.9+ in the test script and test cases, which is a good practice to ensure compatibility. However, the version check in the test script uses a comparison that might not be intuitive at first glance. It would be clearer to use a more explicit comparison for readability.

Workflow ID: wflow_eOExZTSDVU7JndPF


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

.ci/test.sh Show resolved Hide resolved
Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will get easier if we drop 3.8 support, right? It's EOL officially now.

@skrawcz skrawcz merged commit 3d98be3 into main Nov 18, 2024
24 checks passed
@skrawcz skrawcz deleted the temp-branch branch November 18, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants