Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor documentation structure for issue #1043 #1199

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Bhabuk10
Copy link

Pull Request Template

Description

This pull request aims to improve the structure of the Hamilton documentation, enhancing clarity and usability as the documentation grows.

Changes

  • Refactored the documentation structure by separating the "Integrations" section into:

    • Plugins: Libraries that Hamilton has extensions for.
    • Cookbook: Examples on how to use FastAPI with Hamilton.

How I tested this

  • Reviewed the modified documentation files in the docs folder to ensure that the new structure is clear and that all links and references work correctly.
  • Confirmed that the updated documentation renders properly without any formatting issues.

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to bc8442f in 33 seconds

More details
  • Looked at 2922 lines of code in 37 files
  • Skipped 153 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. docs/integrations/index.rst:3
  • Draft comment:
    The title 'Documentation' might be misleading as this section specifically deals with integrations. Consider renaming it to something more specific like 'Integration Documentation' or 'Integration Guides'.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR refactors the documentation structure, which is a non-functional change. The changes are mostly related to restructuring the documentation files and ensuring links and references are correct. The PR description indicates that the changes have been tested for rendering and link correctness. The added files seem to be related to documentation and environment setup, which aligns with the PR's goal. There are no apparent code changes that would affect functionality, so the review should focus on the documentation structure and content.
2. hamilton/env1/share/jupyter/labextensions/jupyterlab-plotly/static/third-party-licenses.json:7
  • Draft comment:
    Avoid logging or exposing sensitive information such as license texts inappropriately.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    License texts are generally not considered sensitive information. They are often included in software distributions to comply with open-source license requirements. The comment seems to misunderstand the nature of license texts, which are meant to be publicly accessible.
    There might be specific contexts where license texts could be considered sensitive, but this is unlikely. The comment does not provide any specific reasoning or context for why these license texts would be sensitive.
    Given the context of software development and open-source licenses, it is reasonable to assume that license texts are not sensitive information. The comment does not provide sufficient justification for its claim.
    The comment should be deleted as it incorrectly categorizes license texts as sensitive information.

Workflow ID: wflow_tZmsJI0sn5vQAOCQ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Bhabuk10
Copy link
Author

@skrawcz @zilto I've submitted a pull request with my changes; please review them and let me know if any adjustments are needed.

Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bhabuk10 it looks like you included your entire environment? hamilton/env1 Please remove it.

@Bhabuk10
Copy link
Author

@skrawcz Done !

@skrawcz
Copy link
Collaborator

skrawcz commented Oct 23, 2024

@skrawcz Done !

I don't see any updates?

@skrawcz
Copy link
Collaborator

skrawcz commented Oct 23, 2024

@Bhabuk10 we need to resolve the warnings for the build to pass before I can see what documentation looks like - https://readthedocs.org/projects/hamilton/builds/26045579/

It seems like some TOC files can't be read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants