Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/#16] 착한 밥상 & 예비 착한 밥상 페이지 구현 #18

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

seoyeonsw
Copy link
Contributor

✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁

  • merge할 브랜치의 위치를 확인해 주세요.(main❌/develop⭕)
  • 리뷰가 필요한 경우 리뷰어를 지정해 주세요.
  • 리뷰는 PR이 올라오면 최대한 빠르게 진행합니다.
  • P1 단계의 리뷰는 빠르게 확인 후 반영합니다.
  • Approve된 PR은 assigner가 머지하고, 수정 요청이 온 경우 수정 후 다시 push를 합니다.

📌 𝗜𝘀𝘀𝘂𝗲𝘀

📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻

  • 착한 밥상 페이지와 예비 착한 밥상 페이지 구현했습니다!

📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁

Screen_recording_20241107_155338.mp4

💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀

@seoyeonsw seoyeonsw self-assigned this Nov 7, 2024
@seoyeonsw seoyeonsw requested a review from a team as a code owner November 7, 2024 07:01
Copy link
Contributor

@gaeulzzang gaeulzzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navigator 직접 전달하지 말고 route에서 화면 이동 로직 작성해주세용!! 그리고 item도 navigator 전달하지 말고 클릭 콜백 함수만 전달해주세용!!

Copy link
Contributor

@gaeulzzang gaeulzzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안드 짱이다 💚

@seoyeonsw seoyeonsw merged commit d27f87e into develop Nov 7, 2024
1 check passed
@gaeulzzang gaeulzzang deleted the feature/#16-babsang-prebabsang-ui branch November 7, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] : 착한 밥상 & 예비 착한 밥상 페이지 구현
2 participants