[audit] 4. Missing validation of submission policy during contract migration

[NoahSaso]

From Oak:

In packages/dao-pre-propose-base/src/execute.rs:670, the migrate function allows the contract migration admin to set the PreProposeSubmissionPolicy when updating the contract. However, no validation ensures the supplied policy does not accidentally lock the DAO due to an invalid configuration.

We classify this issue as minor because it can only caused by the contract migration admin, which is a privileged account.

This fix adds validation to the migration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (75272b9) to head (1d4d2ca).

Additional details and impacted files

@@             Coverage Diff              @@
##           development     #866   +/-   ##
============================================
  Coverage        96.64%   96.65%           
============================================
  Files              240      240           
  Lines            65294    65296    +2     
============================================
+ Hits             63106    63109    +3     
+ Misses            2188     2187    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.