Distribution #792
Closed
Distribution #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeHartnell
commented
Jan 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #792 +/- ##
===============================================
+ Coverage 96.26% 96.41% +0.15%
===============================================
Files 209 214 +5
Lines 53514 55938 +2424
===============================================
+ Hits 51513 53933 +2420
- Misses 2001 2005 +4 ☔ View full report in Codecov by Sentry. |
JakeHartnell
force-pushed
the
distribution
branch
from
93c4815
to
0794f49
Compare
bekauz
reviewed
Apr 7, 2024
Works with token factory DAOs.
cw4-group DAOs are not yet fully working...
To get rewards working with dao-voting-cw4, we needed to add a height to the VotingPowerAtHeight and TotalPowerAtHeight queries.
JakeHartnell
force-pushed
the
distribution
branch
from
abbacfb
to
52caad6
Compare
|
Note sure why CodeCov is failing, but everything else passes. 🤷♂️ |
bekauz
approved these changes
Apr 13, 2024
passes now! |
|
closing in favor of #835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #667 🎉
User Story: As a DAO, I want to distribute rewards over time to members based on their voting power or stake.
This PR refactors the old
cw20-stake-external-rewardsinto something that can be used by all types of DAOs. I've tried my best to add more code comments and documentation into this contract as well, hoping to make it a bit more readable as we move forward.Additionally, I created a new folder
distributionas there was starting to be too much in theexternalcontracts folder. I movedcw-fund-distributorthere for now.As for
cw20-stake-external-rewards, I have left it where it is for now, but thinking about deleting it...