Added message to reset approver back to DAO #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #774 +/- ##
===============================================
- Coverage 96.32% 96.25% -0.07%
===============================================
Files 203 203
Lines 50186 50222 +36
===============================================
Hits 48341 48341
- Misses 1845 1881 +36 ☔ View full report in Codecov by Sentry. |
NoahSaso
force-pushed
the
noah/add-approver-reset
branch
from
2a219e9
to
1f578a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #774 +/- ##
===============================================
+ Coverage 96.45% 96.50% +0.04%
===============================================
Files 204 204
Lines 52395 52518 +123
===============================================
+ Hits 50537 50680 +143
+ Misses 1858 1838 -20 ☔ View full report in Codecov by Sentry. |
JakeHartnell
approved these changes
Nov 28, 2023
NoahSaso
force-pushed
the
noah/add-approver-reset
branch
from
1f578a6
to
f4dd793
Compare
JakeHartnell
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, setting up the
dao-pre-propose-approvercontract is a one-way operation. Once thedao-pre-propose-approval-single'sapproveris set to the approver contract, there is no way to reset it back to the DAO. This is because the approval-single contract requires the current approver to be the one calling theupdate_approverexecute message.This PR adds a message to the approver contract to undo its setup, setting the approver back to the DAO and unregistering the proposal completed hook.