fix bug on bounty update #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taitruong
commented
Aug 19, 2023
| @@ -259,7 +259,9 @@ pub fn update( | |||
| } | |||
| Ordering::Less => { | |||
| // If new amount is less, pay out difference to owner | |||
| let diff = old_amount.amount - new_amount.amount; | |||
| // in case owner accidentally sent funds, send back as well | |||
| let funds_send = may_pay(&info, &bounty.amount.denom)?; | |||
There was a problem hiding this comment.
This is the fix for the bug - also check test below.
| .update( | ||
| 1, | ||
| coin(300, "ujuno"), | ||
| // case: update bounty with lower amount + owner accidentally send funds |
| ) | ||
| .unwrap(); | ||
| // - assert bounty |
There was a problem hiding this comment.
additional check on Bounty state for making sure all is fine - especially checking in tests for update and payout below.
|
Question is whether for |
JakeHartnell
pushed a commit
that referenced
this pull request
Nov 9, 2023
* check Bounty is correct in all tests * fix update bounty with lower amount and owner accidentally send funds * cleanup and test update with sending wrong denom
JakeHartnell
pushed a commit
that referenced
this pull request
Dec 29, 2023
* check Bounty is correct in all tests * fix update bounty with lower amount and owner accidentally send funds * cleanup and test update with sending wrong denom
JakeHartnell
pushed a commit
that referenced
this pull request
Jan 8, 2024
* check Bounty is correct in all tests * fix update bounty with lower amount and owner accidentally send funds * cleanup and test update with sending wrong denom
JakeHartnell
pushed a commit
that referenced
this pull request
Mar 26, 2024
* check Bounty is correct in all tests * fix update bounty with lower amount and owner accidentally send funds * cleanup and test update with sending wrong denom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug in contract: