Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support different NFT contracts with dao-voting-cw721-staked #726

Merged
merged 6 commits into from
Aug 20, 2023
Merged

Support different NFT contracts with dao-voting-cw721-staked #726

merged 6 commits into from
Aug 20, 2023

Conversation

JakeHartnell
Copy link
Member

@JakeHartnell JakeHartnell commented Aug 10, 2023 •
edited
Loading

Now works with sg721 as well as some custom cw721 contracts. 🥳

Closes #716

@JakeHartnell
Support a wider variety of NFT contracts
a4b64c6 
Makes the interface for instantiating a new collection a bit more generic
to account for most types of cw721 and sg721 contracts.
@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Patch coverage: 96.15% and project coverage change: +0.06% 🎉

Comparison is base (ec13a79) 93.98% compared to head (d62157b) 94.04%.
Report is 1 commits behind head on development.

Additional details and impacted files 
@@               Coverage Diff               @@
##           development     #726      +/-   ##
===============================================
+ Coverage        93.98%   94.04%   +0.06%     
===============================================
  Files               62       62              
  Lines             5600     5610      +10     
===============================================
+ Hits              5263     5276      +13     
+ Misses             337      334       -3
Files Changed Coverage Δ
...tracts/voting/dao-voting-cw721-staked/src/state.rs 100.00% <ø> (ø)
...cts/voting/dao-voting-cw721-staked/src/contract.rs 95.15% <96.15%> (+0.59%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NoahSaso
NoahSaso requested changes Aug 14, 2023
View reviewed changes
Copy link
Member

@NoahSaso NoahSaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks goooood to me, we should test it on both stargaze and juno testnets before merging

contracts/voting/dao-voting-cw721-staked/src/contract.rs Outdated Show resolved Hide resolved
contracts/voting/dao-voting-cw721-staked/src/testing/tests.rs Outdated Show resolved Hide resolved
@JakeHartnell
Address PR comments, check errors
3465e7f
@JakeHartnell
Apply @bekauz's suggestion
99ab6b0
@JakeHartnell
Add migrate message
7064dee 
New features don't require any state migrations. Both `ACTIVE_THRESHOLD` and `HOOKS` are uninitialized if none are set, so no migration logic needed.
@JakeHartnell JakeHartnell mentioned this pull request Aug 19, 2023
Closed
NoahSaso
NoahSaso approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@NoahSaso NoahSaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yes this looks so good!!

@JakeHartnell JakeHartnell merged commit 7756251 into development Aug 20, 2023
8 checks passed
@JakeHartnell JakeHartnell deleted the sg721-daos branch August 20, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bekauz bekauz bekauz left review comments

@NoahSaso NoahSaso NoahSaso approved these changes

@Art3miX Art3miX Awaiting requested review from Art3miX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeHartnell @NoahSaso @bekauz