Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish v2.2.0 #719

Merged
merged 30 commits into from
Jul 9, 2023
Merged

Publish v2.2.0 #719

merged 30 commits into from
Jul 9, 2023

Conversation

JakeHartnell
Copy link
Member

@JakeHartnell JakeHartnell commented Jul 6, 2023

There are no functionality changes in this release, just renaming of packages (because of name collisions in crates.io) as well as moving stuff around to reduce circular dependencies so we can publish all the DAO DAO packages. Also fixes up CI as nightly changes have broken it.

Closes #242. Finally. 🥳

NOTE: have tested the publish script, will tag v2.2.0 last after getting this reviewed.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
@JakeHartnell JakeHartnell marked this pull request as ready for review July 6, 2023 15:34
@JakeHartnell JakeHartnell mentioned this pull request Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (9261bb3) 93.97% compared to head (23aa976) 93.94%.

❗ Current head 23aa976 differs from pull request most recent head 9a6d905. Consider uploading reports for the commit 9a6d905 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
- Coverage   93.97%   93.94%   -0.04%     
==========================================
  Files          60       60              
  Lines        5214     5215       +1     
==========================================
- Hits         4900     4899       -1     
- Misses        314      316       +2     
Impacted Files Coverage Δ
contracts/dao-dao-core/src/contract.rs 97.61% <ø> (ø)
...racts/external/cw-fund-distributor/src/contract.rs 94.52% <ø> (ø)
...se/dao-pre-propose-approval-single/src/contract.rs 87.21% <ø> (ø)
...e-propose/dao-pre-propose-approver/src/contract.rs 91.89% <ø> (ø)
contracts/staking/cw20-stake/src/contract.rs 90.30% <ø> (ø)
...cts/voting/dao-voting-cw721-staked/src/contract.rs 96.42% <ø> (ø)
...ts/voting/dao-voting-native-staked/src/contract.rs 95.83% <ø> (ø)
packages/cw-paginate-storage/src/lib.rs 94.23% <ø> (ø)
packages/dao-pre-propose-base/src/state.rs 100.00% <ø> (ø)
packages/dao-voting/src/pre_propose.rs 100.00% <ø> (ø)
... and 9 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@NoahSaso NoahSaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sick!! just a few notes

Cargo.toml Outdated Show resolved Hide resolved
contracts/README.md Outdated Show resolved Hide resolved
contracts/dao-dao/Cargo.toml Outdated Show resolved Hide resolved
contracts/dao-dao/README.md Outdated Show resolved Hide resolved
contracts/dao-dao/src/contract.rs Outdated Show resolved Hide resolved
packages/cw-hooks/src/lib.rs Show resolved Hide resolved
packages/cw-hooks/src/lib.rs Show resolved Hide resolved
packages/dao-pre-propose-base/src/msg.rs Outdated Show resolved Hide resolved
packages/dao-pre-propose-base/src/state.rs Outdated Show resolved Hide resolved
@JakeHartnell
Copy link
Member Author

@NoahSaso, have another look, I think we are good.

Copy link
Collaborator

@bekauz bekauz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JakeHartnell JakeHartnell merged commit 7f89ad1 into main Jul 9, 2023
@JakeHartnell JakeHartnell deleted the publish-v2.2.0 branch July 9, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish packages
3 participants