Allow voting up to expiration time

[nlipartiia-hacken]

Closes #463.

[0xekez]

hey! thanks for putting this together! skimmed this and it looks good. we're really busy trying to get v2 released here so might be a couple days before i can get to a proper review. <3

[blue-note]

apologies for the delay in reviewing here -- lets push this through! Also, for the integration test failure, rebasing on main should fix it.

[nlipartiia-hacken]

thanks for the review! I rebased over main, hope it fixes the failure

[0xekez]

thanks for the PR! i think this would be a really nice change to do some fuzzing on. specifically, the assertion we're making here that:

if a proposal's outcome has been determined, no sequence of additional votes will cause that outcome to change.

you could probably fuzz this pretty easily by manually selecting a number of interesting "passed" vote counts, generating a sequence of random votes, casting those votes, and then making sure the proposal's outcome has not changed.

if you'd like some example code to build this on top of, i did something pretty similar recently to fuzz a rate limiter here.

any time we change vote casting code, it is pretty high risk. testing this really well would make me feel good about these changes.

[0xekez]

closing this for now. @NinoLipartiia if you have plans for picking this up feel free to just push to this branch and we'll reopen and do more review :) just want to clear the pr queue.

[bekauz]

I'll pick this up

[JakeHartnell]

Great work! Thanks for helping this get across the finish line for v2.

[0xekez]

amazing work. thank you @bekauz !