Skip to content

Commit

Permalink
Merge pull request #1 from D-Nice/feat/eslint
Browse files Browse the repository at this point in the history
feat/eslint
  • Loading branch information
D-Nice authored Sep 3, 2019
2 parents 9617c73 + 8507470 commit f4e9fc0
Show file tree
Hide file tree
Showing 17 changed files with 429 additions and 246 deletions.
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
public/
129 changes: 129 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
module.exports = {
parser: 'babel-eslint',
parserOptions: {
ecmaVersion: 2018,
ecmaFeatures: {
impliedStrict: true,
jsx: true,
modules: true
}
},
extends: [
'eslint:recommended',
'plugin:react/recommended',
'standard'
],
settings: {
react: {
version: 'detect'
}
},
env: {
es6: true,
mocha: true,
node: true
},
// ADD ANY GLOBALS HERE!
globals: {
},
rules: {
quotes: [2, 'single', { avoidEscape: true }],
'no-template-curly-in-string': 2,
'no-extra-parens': [1, 'all'],
'no-misleading-character-class': 1,
'no-prototype-builtins': 1,
'no-async-promise-executor': 1,
'no-await-in-loop': 0, // should probably be on for perf dependent application
'require-atomic-updates': 1,
// best practices
'accessor-pairs': 1,
'array-callback-return': 0, // this best practice calls out the use of map over forEach
'class-methods-use-this': 1,
'complexity': [1, 9],
'curly': [1, 'multi-or-nest', 'consistent'],
'dot-location': [2, 'property'],
'no-empty-function': 1,
'no-eval': 2,
'no-extend-native': 1,
'no-extra-bind': 1,
'no-implicit-coercion': 1,
'no-implicit-globals': 2,
'no-implied-eval': 2,
'no-lone-blocks': 1,
'no-loop-func': 1,
'no-magic-numbers': 0, // could be useful?
'no-new': 1,
'no-new-func': 2,
'no-new-wrappers': 1,
'no-param-reassign': 2,
'no-redeclare': [2, { 'builtinGlobals': true }],
'no-shadow': [2, {
'builtinGlobals': true,
'allow': [
'done',
'resolve',
'reject',
'cb' // x could potentially be added
]
}],
'no-return-await': 1,
'no-script-url': 1,
'no-self-compare': 1,
'no-sequences': 1,
'no-throw-literal': 2,
'no-unmodified-loop-condition': 1,
'no-useless-call': 1,
'no-useless-catch': 1,
'no-useless-concat': 2,
'no-useless-escape': 2,
'no-useless-return': 0,
'no-console': ['error', {
allow: [
'warn',
'error',
'info'
]
}],
'no-warning-comments': [1, {
terms: [
'fixme',
'todo',
'note'
],
location: 'anywhere' // useful to highlight comments that need addressing
}],
'require-await': 1,
'vars-on-top': 2,
'wrap-iife': [2, 'inside'],
// strict mode
'strict': [2, 'safe'],
// variables
'no-use-before-define': [2, {
variables: true,
functions: true,
classes: true
}],
// node
'handle-callback-err': 1,
'no-buffer-constructor': 2,
'no-mixed-requires': 2,
'no-new-require': 0,
'no-path-concat': 1,
'no-sync': 1,
'class-methods-use-this': [1, {
'exceptMethods': [
'componentDidMount',
'componentDidUpdate',
'componentWillMount',
'componentWillReceiveProps',
'componentWillUnmount',
'componentWillUpdate',
'render',
'shouldComponentUpdate',
]
}]
// stylistic (leaving up to standard)

// ECMAScript 6 (tbd)
}
}
5 changes: 0 additions & 5 deletions .prettierrc

This file was deleted.

27 changes: 20 additions & 7 deletions config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,25 @@ module.exports = {
manifestThemeColor: '#34d12e',
manifestDisplay: 'standalone',
manifestIcon: 'src/assets/img/website-icon.png',
pathPrefix: `/`,
pathPrefix: '/',
heading: 'solinfra',
subHeading: '... building the clouds of tomorrow, today',

// projects
// about
about: {
title: 'The solution to infrastructure',
body: `
Whether you're a start-up with the foresight of appropriately preparing
for your infrastructure needs or
an already established organization looking to upgrade your legacy IT
infrastructure, we‘re here for you.
Our experienced team will blueprint and manage the ideal
infrastructure to make your service run efficiently, with resilience and
scalablity in mind.
`

},
// projects
projects: [
{
title: 'Balancing NoOps and DevOps',
Expand Down Expand Up @@ -76,14 +89,14 @@ module.exports = {
{
icon: 'fa-twitter',
name: 'Twitter',
url: 'https://twitter.com/solinfra',
url: 'https://twitter.com/solinfra'
},
{
icon: 'fa-github',
name: 'Github',
url: 'https://github.com/solinfra',
},
url: 'https://github.com/solinfra'
}
],
email: '[email protected]',
address: 'Suite 1801 - 1 Yonge Street, Toronto, Canada, M5E 1W7',
};
address: 'Suite 1801 - 1 Yonge Street, Toronto, Canada, M5E 1W7'
}
28 changes: 14 additions & 14 deletions gatsby-config.js
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
const config = require('./config');
const config = require('./config')

module.exports = {
pathPrefix: config.pathPrefix,
siteMetadata: {
title: config.siteTitle,
title: config.siteTitle
},
plugins: [
'gatsby-plugin-react-helmet',
{
resolve: `gatsby-plugin-manifest`,
resolve: 'gatsby-plugin-manifest',
options: {
name: config.manifestName,
short_name: config.manifestShortName,
start_url: config.pathPrefix || config.manifestStartUrl,
background_color: config.manifestBackgroundColor,
theme_color: config.manifestThemeColor,
display: config.manifestDisplay,
icon: config.manifestIcon, // This path is relative to the root of the site.
},
icon: config.manifestIcon // This path is relative to the root of the site.
}
},
'gatsby-plugin-sass',
'gatsby-plugin-offline',
{
resolve: 'gatsby-plugin-svgr',
options: {
prettier: true, // use prettier to format JS code output (default)
svgo: false, // use svgo to optimize SVGs (default)
},
},
],
};
{
resolve: 'gatsby-plugin-svgr',
options: {
prettier: true, // use prettier to format JS code output (default)
svgo: false // use svgo to optimize SVGs (default)
}
}
]
}
Loading

0 comments on commit f4e9fc0

Please sign in to comment.