Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support constructor injection with IConnectionMultiplexerFactory #108

Merged
merged 1 commit into from
May 22, 2023
Merged

Support constructor injection with IConnectionMultiplexerFactory #108

merged 1 commit into from
May 22, 2023

Conversation

mayuki
Copy link
Member

@mayuki mayuki commented May 22, 2023

This PR adds support constructor injection with IConnectionMultiplexerFactory.
This covers use cases where you want to use registered services or options when getting IConnectionMultiplexerFactory.

services.AddMesagePipeRedis<MyConnectionMultiplexerFactory>();
...

class MyConnectionMultiplexerFactory : IConnectionMultiplexerFactory
{
    public MyConnectionMultiplexerFactory(IOptions<MyConnectionMultiplexerOption> options) { ... }
}

Breaking changes

  • Remove ConnectionMultiplexerFactory property from MessagePipeRedisOptions

@neuecc
Copy link
Member

neuecc commented May 22, 2023

seems good!

@neuecc neuecc merged commit 5d3b2b8 into master May 22, 2023
@neuecc neuecc deleted the feature/SupportDIForConnectionMultiplexerFactory branch May 22, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayuki @neuecc