Upgrade poison to 3.0 #35
Conversation
1 similar comment
|
how can it be decreased if I've only changed mix.exs and mix.lock? |
|
Thanks @vyorkin! This removes compatibility for versions 1.x and 2.x of poison which I'd rather avoid. Sadly, poison doesn't include a CHANGELOG to see what justified their major version bump (normally used for backward incompatible changes in Semver). Can you change the dependency so that all versions are allowed? |
|
just to be clear, you want all versions to be allowed |
| {:towel, "~> 0.2"}, | ||
| {:poolboy, "~> 1.5"}, | ||
| {:geohash, "~> 0.1"}, | ||
| {:ex_doc, ">= 0.0.0", only: :dev}, | ||
| {:inch_ex, only: :docs}, | ||
| {:inch_ex, ">= 0.0.0", only: :docs}, |
There was a problem hiding this comment.
had to change this to suppress warning
mix.exs
Outdated
| @@ -27,12 +27,12 @@ defmodule Geocoder.Mixfile do | |||
|
|
|||
| defp deps do | |||
| [{:httpoison, "~> 0.8"}, | |||
| {:poison, "~> 3.0"}, | |||
| {:poison, ">= 0.0.0"}, | |||
There was a problem hiding this comment.
I assume you want to completely relax the dependency
There was a problem hiding this comment.
Sorry, @vyorkin, for not getting back to you earlier. Coming back to your question further up, I think I would prefer < 4.0.0 in case poison ever starts to submit a changelog.
There was a problem hiding this comment.
got it, will update in a minute
3 similar comments
|
Thank you, @vyorkin ! |
same as #16 , but bumps poison to 3.0 and has no conflicts