Skip to content
This repository has been archived by the owner on Apr 6, 2019. It is now read-only.

when connect timeout is 0, connnect fail on same operating systems. #32

Closed
yuangu opened this issue Oct 26, 2017 · 2 comments
Closed

when connect timeout is 0, connnect fail on same operating systems. #32

yuangu opened this issue Oct 26, 2017 · 2 comments

Comments

@yuangu
Copy link
Contributor

yuangu commented Oct 26, 2017

Some operating systems (such as IOS), socket defaults to non blocking. When the connect set to timeout is 0, the connection will fail.

sorry for my poor english.^_^
@Cylix
Copy link
Owner

Cylix commented Nov 3, 2017

Hi,

Thanks for reporting this issue and sorry for the delay to get back to you!
That's indeed a good observation, I'm going to have a look into this to fix it ASAP :)

Best

Cylix added a commit that referenced this issue Nov 13, 2017
@Cylix
make sure socket is in blocking mode before connection (#32) and chec…
7aac28e 
…k for async-connect errors with getsockopt
Cylix added a commit that referenced this issue Nov 13, 2017
@Cylix
make sure socket is in blocking mode before connection (#32) and chec…
c6e5399 
…k for async-connect errors with getsockopt
@Cylix
Copy link
Owner

Cylix commented Nov 13, 2017

Hi,

Sorry for the delay to process this issue.
This should now be fixed: I made sure that the socket is always in blocking mode if no timeout is defined.
If you happen to test the fix, let me know if it works on your side or not.

Best

@Cylix Cylix closed this as completed Nov 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuangu @Cylix