Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Leak of Ingredients #1049

Closed
pietro-lopes opened this issue Aug 20, 2024 · 2 comments
Closed

Memory Leak of Ingredients #1049

pietro-lopes opened this issue Aug 20, 2024 · 2 comments
Labels
mc-1.21 performance

Comments

@pietro-lopes
Copy link

Issue type:

  • 🐌 Performance issue

Short description:

Ingredient is being stored in Identity Map without any cleanup on reload logic.

Steps to reproduce the problem:

  1. join game
  2. use your IDE to watch for SanguinaryEnvironmentalAccumulatorRecipeJEI.RECIPE_WRAPPERS_2

1st load:
image

2nd load:
image

Versions:

  • This mod: 1.2.51
  • Minecraft: 1.21.1
  • Forge: 21.1.21

Profiler output:
@rubensworks
Copy link
Member

Thanks for reporting!

@pietro-lopes pietro-lopes mentioned this issue Aug 20, 2024
Open
@rubensworks
Copy link
Member

Ouch, good catch. Looks like this one has been around for a long time.

@github-project-automation github-project-automation bot moved this from To Do to Done in Maintenance Aug 21, 2024
rubensworks added a commit that referenced this issue Aug 21, 2024
@rubensworks
Bump compat version
f5daa6b 
Fixes:
* Fix JEI memory leak, Closes #1049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mc-1.21 performance
Projects
Maintenance
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rubensworks @pietro-lopes