-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: make metadata field description more clear #370
docs: make metadata field description more clear #370
Conversation
fix CycloneDX#345 CycloneDX#273 Signed-off-by: Jan Kowalleck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only minor nitpicks
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
771cfe5
to
250dd20
Compare
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why BOM
was changed to document
?
Because the described fields do not only apply to BOM, but also to VEX, VDR and anything else that we do not have considered as a use case. It is a general-purpose field not bound to any specific purpose, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is a dedicated PR specific to the manufacturer descriptive text, perhaps leave it out of this one and then link them making this one a pre-req of the the other.
no need to think about such things. this is what SCM is for, and it will handle it. the actual thing we need to think about are the possible breaking changes that are coming with the documentation. |
@mrutkows you requested a change of this PR (via your review), |
I took your comments and will propose an alternative solution, |
I prefer "BOM" to "document". Yes, I know that CycloneDX does other things, but its primarily a BOM format. A "document" is not applicable to protobuf and any JSON/XML over an API. The word "document" just feeds wrong, feels old |
closed this PR> |
fixes #345
fixes #273
parts are superseded by #378
parts are continued in #379