Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make metadata field description more clear #370

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Feb 6, 2024

fixes #345
fixes #273


parts are superseded by #378
parts are continued in #379

@jkowalleck jkowalleck requested a review from a team as a code owner February 6, 2024 17:01
@jkowalleck jkowalleck changed the title make metadata field descibtion more clear. docs: make metadata field description more clear Feb 6, 2024
@jkowalleck jkowalleck added this to the 1.6 milestone Feb 6, 2024
Copy link

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only minor nitpicks

schema/bom-1.6.schema.json Show resolved Hide resolved
schema/bom-1.6.schema.json Outdated Show resolved Hide resolved
schema/bom-1.6.schema.json Outdated Show resolved Hide resolved
schema/bom-1.6.schema.json Outdated Show resolved Hide resolved
schema/bom-1.6.xsd Outdated Show resolved Hide resolved
schema/bom-1.6.proto Outdated Show resolved Hide resolved
schema/bom-1.6.proto Outdated Show resolved Hide resolved
schema/bom-1.6.proto Outdated Show resolved Hide resolved
schema/bom-1.6.schema.json Outdated Show resolved Hide resolved
schema/bom-1.6.xsd Outdated Show resolved Hide resolved
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck force-pushed the 1.6-dev_docs-meta-supplier_fix345_fix273 branch from 771cfe5 to 250dd20 Compare February 8, 2024 11:46
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck mentioned this pull request Feb 8, 2024
4 tasks
Copy link
Member

@stevespringett stevespringett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why BOM was changed to document?

@jkowalleck
Copy link
Member Author

jkowalleck commented Feb 10, 2024

Any reason why BOM was changed to document?

Because the described fields do not only apply to BOM, but also to VEX, VDR and anything else that we do not have considered as a use case. It is a general-purpose field not bound to any specific purpose, right?

Copy link
Contributor

@mrutkows mrutkows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is a dedicated PR specific to the manufacturer descriptive text, perhaps leave it out of this one and then link them making this one a pre-req of the the other.

schema/bom-1.6.proto Show resolved Hide resolved
@jkowalleck
Copy link
Member Author

jkowalleck commented Feb 12, 2024

Since there is a dedicated PR specific to the manufacturer descriptive text, perhaps leave it out of this one and then link them making this one a pre-req of the the other.

no need to think about such things. this is what SCM is for, and it will handle it.
especially since this PR is about documentation, and the other one is about a feature (that involves some documentation).

the actual thing we need to think about are the possible breaking changes that are coming with the documentation.

@jkowalleck
Copy link
Member Author

jkowalleck commented Feb 12, 2024

@mrutkows you requested a change of this PR (via your review),
but i do not understand that you want to have changed. Could you clarify?

@jkowalleck jkowalleck marked this pull request as draft February 14, 2024 12:22
@jkowalleck
Copy link
Member Author

jkowalleck commented Feb 14, 2024

I took your comments and will propose an alternative solution,
which is highly driven by #372 (comment)

@jkowalleck jkowalleck requested a review from a team February 14, 2024 12:24
@stevespringett
Copy link
Member

I prefer "BOM" to "document". Yes, I know that CycloneDX does other things, but its primarily a BOM format. A "document" is not applicable to protobuf and any JSON/XML over an API. The word "document" just feeds wrong, feels old

@jkowalleck
Copy link
Member Author

closed this PR>
all intended changes were superseded by other PRs, or were not solvable in a non-breaking way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify difference between metadata.licenses and metadata.component.licenses
4 participants