Change visibility of model types #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting the visibility of model types to the crate level, these types are public now. The model types can be used by external crates directly. * fix clippy lints Signed-off-by: Sebastian Ziebell <[email protected]>
|
Awesome! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the visibility of model types to the crate level, types are public now. When building the BOM some of the models were not able to be constructed. With the change inner BOM model types can now be constructed / used by external crates directly.
Instead of only adapting the
Cpetype (as given in issue #739) all types in the/modelsfolder are public now, including their associated validation functions.Closes #739