Fix tools type in metadata #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tools` type in `metadata` allows optional `services` & `components` fields in the 1.5 specification. These are not required therefore these fields are changed to `Option` fields. Previously this has not been covered by tests. Signed-off-by: Sebastian Ziebell <[email protected]>
lfrancke
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Looking good to me. I'll approve but we can give others a chance as well.
I tested it on my failing BOM and it works now.
I'm wondering what'll happen for items that contain neither services nor components. It's probably still valid either way.
You could update the changelog but I believe @Shnatsel has always done it at release time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
toolstype inmetadataallows optionalservices&componentsfields according the 1.5 specification. These are not required therefore these fields have changed toOptionfields.Previously this has not been covered by tests.