Expose more Details of Purl and Cpe for writing #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, https://github.com/CycloneDX/cyclonedx-rust-cargo/runs/12224035251 Thank you |
Signed-off-by: akoenig <[email protected]>
Signed-off-by: akoenig <[email protected]>
Signed-off-by: akoenig <[email protected]>
Shnatsel
approved these changes
Oct 23, 2023
Shnatsel
requested changes
Oct 27, 2023
| @@ -60,6 +60,12 @@ impl Validate for Purl { | |||
| } | |||
| } | |||
|
|
|||
| impl<'a> From<PackageUrl<'a>> for Purl { | |||
There was a problem hiding this comment.
The PackageUrl crate currently has version 0.3.0, not 1.0 or something like that. It is likely that they will bump the version frequently. If we provide a From<PackageUrl> implementation, that will expose the PackageUrl type in the public API, and require an incompatible SemVer change to this crate every time the SemVer of PackageUrl is bumped.
Could you provide a FromStr implementation instead?
Shnatsel
approved these changes
Oct 29, 2023
|
Thanks! Just needs a signoff with |
Signed-off-by: akoenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.