-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added PDM support for generating the SBOM file #603
Conversation
thank you for the initiative, @rios0rios0 Before we even take a look at your implementation, We then might discuss the feature and implications Until a conclusion regarding feature adoption is made, this PR will set to "DRAFT". |
Thanks @jkowalleck. There's still some work that needs to be done. We'll create and issue and I'm in the process of writing some tests. For the time being we'll just need this PR to be here as a stub. We'll ping you when we think it's ready. |
Signed-off-by: k4yt3x <[email protected]>
the project is currently undergoing a complete restructuring process (see #610) i will keep you posted as soon as a previous version exists, so you could base your work in it |
re: #603 (comment) @rios0rios0 @k4yt3x please rebase onto branch I hope you will understand the new structures and concepts, and see how unit/integration tests are to be structured. |
Hello @jkowalleck, We're just returning from the holidays and hope you had a wonderful Christmas and New Year. We have reviewed the new structure, and honestly, it's been somewhat difficult for us to grasp the new concepts. Adding PDM support for At this point, since our enhancements based on a fork of 3.11.7 already meet our internal requirements, rebasing it onto If you're interested, we can still generate all the tests and documentation for our current changes based on 3.11.7 for potential merging. Otherwise, considering the amount of work we currently have, we will need to defer submitting PDM support to upstream. |
Please do so. This would help tremendously. compare existing testbeds: https://github.com/CycloneDX/cyclonedx-python/tree/dev/4.0.0/tests/_data/infiles |
@jkowalleck We proposed to write tests for 3.x.x but you referenced the tests for 4.0.0. I'm slightly confused. |
Actually I don't need tests written in python, but I really need test-beds for your use cases - just like the ones I linked. |
Hi again. I had no clue what the test data files are like when you sent them, so I parked this project for a bit and finally got time to take another look at this project today. "Our use cases" would be internal projects so I don't think it's possible for me to provide them. The original purpose of this PR is to see if the upstream could use our changes for 3.x.x. We tested the new 4.x.x version and the |
Description
Here we are adding support for PDM.
Closes #604.
Requirements
Checklist