Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #263, handling ci-friendly properties in the parent references #334

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Fix issue #263, handling ci-friendly properties in the parent references #334

merged 3 commits into from
Apr 13, 2023

Conversation

knrc
Copy link
Contributor

@knrc knrc commented Apr 11, 2023 •
edited by hboutemy
Loading

This PR updates #292 with the fix for #263

@knrc knrc changed the title Issue 263 Fix issue 263, handling properties in the parent references Apr 11, 2023
@knrc knrc mentioned this pull request Apr 11, 2023
Closed
@hboutemy hboutemy self-requested a review April 13, 2023 12:12
hboutemy
hboutemy approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@hboutemy hboutemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, such a simple change to fix such a complex issue :)
thanks Kevin

@hboutemy hboutemy added this to the 2.7.7 milestone Apr 13, 2023
@hboutemy hboutemy merged commit 5fa76c4 into CycloneDX:master Apr 13, 2023
@hboutemy hboutemy linked an issue Apr 13, 2023 that may be closed by this pull request
Attribute "dependsOn" empty for parent module in multimodule ci-friendly maven project #263
Closed
@hboutemy hboutemy changed the title Fix issue 263, handling properties in the parent references Fix issue #263, handling properties in the parent references Apr 13, 2023
@hboutemy hboutemy added the bug label Apr 13, 2023
@hboutemy hboutemy changed the title Fix issue #263, handling properties in the parent references Fix issue #263, handling ci-friendly properties in the parent references Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboutemy hboutemy hboutemy approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.7.7
Development

Successfully merging this pull request may close these issues.

Attribute "dependsOn" empty for parent module in multimodule ci-friendly maven project
2 participants
@knrc @hboutemy