Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add merging functionality #12

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat: add merging functionality #12

wants to merge 6 commits into from

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Oct 15, 2021

🚧 WIP 🚧

This PR aims to introduce functionality to merge multiple BOMs.
There are multiple use cases to be addressed, which is why multiple merging algorithms will be offered.

Merging must behave the same across all CycloneDX implementations.
Documentation on all merging algorithms is currently being worked on and will be published separately.

This PR includes test files that should be used to ensure that merge implementations behave as expected.

Deduplication of BOM elements is out of scope for this PR. It will be implemented in a later iteration.

Addresses #9

@nscuro nscuro changed the title Add merging functionality feat: add merging functionality Jan 1, 2022
@nscuro nscuro added this to the v0.6.0 milestone Feb 4, 2022
@nscuro nscuro force-pushed the 9-merging branch 2 times, most recently from 439de18 to c52251a Compare February 25, 2022 21:11
@nscuro nscuro modified the milestones: v0.6.0, v0.7.0 May 20, 2022
@nscuro nscuro removed this from the v0.7.0 milestone Sep 28, 2022
@manifestori
Copy link

@nscuro Hi! great work on reimplementing the .NET merge into Go.

What preventing us from merging an initial release into main branch?
Do you need help with review / development?

Currently we need to merge SBOM programmatically and do this by using the executable which is, not great. having this functionality merged, means we can merge without external dependencies :)

@young-yang03
Copy link

Is there any update for the SBOM merging feature? when this feature will release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants