Fix for Windows - Control Character breaking tests, validation, dependency tree #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arseBdistMetadata fix Signed-off-by: Caroline Russell <[email protected]>
Signed-off-by: Caroline Russell <[email protected]>
Signed-off-by: Caroline Russell <[email protected]>
prabhu
approved these changes
Aug 2, 2023
cerrussell
changed the title
|
@prabhu I'm going to break out adding windows to repotests into a separate issue - I need to figure out how to expose the daemon without TLS on the github runner. Going to go ahead and merge these other fixes to reduce the number of moving parts I have to deal with in relation to other issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, package parsing by cdxgen on Windows began including a carriage return at the end of metadata fields. This pr just removes that character if it's present so that it won't break sbom validation or tests when running on Windows.