feat: adding dashboard adhoc filters #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reCanada/superset into Adding-Dashboard-Adhoc-Filters
…reCanada/superset into Adding-Dashboard-Adhoc-Filters
…reCanada/superset into Adding-Dashboard-Adhoc-Filters
… Adding-Dashboard-Adhoc-Filters
… Adding-Dashboard-Adhoc-Filters
…o Adding-Dashboard-Adhoc-Filters
… Adding-Dashboard-Adhoc-Filters
cccs-Dustin
suggested changes
Nov 22, 2022
Co-authored-by: cccs-Dustin <[email protected]>
cccs-Dustin
approved these changes
Nov 22, 2022
cccs-RyanS
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Users want to be able to create adhoc filters, similar to the explore view, as a native filter in dashboards. This PR creates a new native filter type called adhoc that puts the same adhoc filter control component in the native filters pane and allows users to create adhoc filters on a dataset in the dashboard.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Go into a dashboard, filter by
ADDITIONAL INFORMATION