Release 1.0.0 #147
Merged
Release 1.0.0 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ added python related files to gitignore
+ this will allow us to convert the source code into a module to implement GH-Actions
+ project can now be installed using 'python -m pip install -e .'
+ black - code formatting + tests - unit tests in py3.7,3.8,3.9 + pre-commit to verify before push "python -m pip install -r dev_requirements.txt"
+ removed python version 3.7 from tox builds + updated default version for pre-commit hooks to python 3.8
This reverts b6723c7
+ Fixed .gitignore to correctly ignore in subdirectories + Changed Dockerfile to install project as module
…trading-bot-binance-announcements-new-coins into feature_github_actions # Conflicts: # Dockerfile # src/main.py
…trading-bot-binance-announcements-new-coins into feature_github_actions # Conflicts: # src/gateio_new_coins_announcements_bot/logger.py # src/gateio_new_coins_announcements_bot/new_listings_scraper.py # src/gateio_new_coins_announcements_bot/send_telegram.py # src/gateio_new_coins_announcements_bot/trade_client.py # src/main.py
…trading-bot-binance-announcements-new-coins into feature_github_actions # Conflicts: # src/gateio_new_coins_announcements_bot/new_listings_scraper.py
+ binancezh.com is no longer a valid binance domain
Changed domain binancezh.com to binance.com
Validate status_code when retrieving announcements
+ make sure all necessary files are copied over before installing
…_module Update requirements + bump pytest-cov to 3.0.0
CyberPunkMetalHead
approved these changes
Jan 17, 2022
|
Looks good to me! Thank you @Linus045 and @AndroidOatmeal!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging the release, we need to check if everything works as expected:
If you have additional points, feel free to add them.