-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 + Mixbox Support #249
Conversation
Create compat.py module to deal with Python2/Python3 dependencies
Removed a couple failing encoding tests that don't reflect what should typically happen in the course of the library being used.
A lot of new code was introduced since the first cut at Python3 compatibility.
|
@bworrell, I know this is a huge change, but do you have time to look at it and provide any feedback? |
@@ -1523,7 +1522,7 @@ def buildChildren(self, child_, node, nodeName_, fromsubclass_=False): | |||
'Fuzzy_Hash_Value': cybox_common.FuzzyHashValueType, | |||
'Show_Message_Title': cybox_common.StringObjectPropertyType, | |||
'Data_Size': cybox_common.DataSizeType, | |||
'Email_Message': email_message_object.EmailMessageObjectType, | |||
'email_message': email_message_object.EmailMessageObjectType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a find-replace gone bad. It pops up in a couple spots. I fixed it in 8327de6.
@gtback, I looked through the code and posted a few comments/questions but overall I think it looks awesome! I ran # For python-stix/python-maec
from mixbox.binding_utils import ExternalEncoding I'm not sure if we want to add the line, or just work towards getting python-stix|maec up and running with |
Partially revert ce549b8
I would lean towards not adding to |
|
@gtback, this looks awesome! I'm gonna merge, though we'll need to update python-stix and python-maec before the next release. Thanks!! |
This obsoletes #228 and incorporates mixbox, with the common "binding utils" delegated to that package. Mixbox natively supports Python 3, and this branch has also been updated to support Python 3.2, 3.3, and 3.4.
This requires mixbox 0.0.2. I didn't explicitly specify a version, since I don't want to remember to bump it each time in several places. If you have a different version of mixbox cached locally with pip, you can just "pip install mixbox==0.0.2" from any virtualenv to download and cache the newest version, which will get used to build new venvs.