Skip to content

Commit

Permalink
misc!: remove identifier attribute
Browse files Browse the repository at this point in the history
This feature has been part of the library since its first public release, but it
was never documented because it did not fit one of the library's main philosophy
which is to be almost entirely decoupled from an application's domain layer.

The feature is entirely removed and not planned to be replaced by an
alternative, unless the community really feels like there is a need for
something alike.
  • Loading branch information
romm committed Nov 23, 2022
1 parent a2bef34 commit 8a7486a
Show file tree
Hide file tree
Showing 8 changed files with 1 addition and 278 deletions.
39 changes: 0 additions & 39 deletions src/Attribute/Identifier.php

This file was deleted.

8 changes: 1 addition & 7 deletions src/Library/Container.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
use CuyZ\Valinor\Mapper\Tree\Builder\ArrayNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Builder\CasterNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Builder\CasterProxyNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Builder\ClassNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Builder\ProxyClassNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Builder\ErrorCatcherNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Builder\InterfaceNodeBuilder;
Expand All @@ -40,13 +41,9 @@
use CuyZ\Valinor\Mapper\Tree\Builder\RootNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Builder\ScalarNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Builder\ShapedArrayNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Builder\ShellVisitorNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Builder\StrictNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Builder\UnionNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Builder\ValueAlteringNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Builder\ClassNodeBuilder;
use CuyZ\Valinor\Mapper\Tree\Visitor\AttributeShellVisitor;
use CuyZ\Valinor\Mapper\Tree\Visitor\ShellVisitor;
use CuyZ\Valinor\Mapper\TreeMapper;
use CuyZ\Valinor\Mapper\TypeArgumentsMapper;
use CuyZ\Valinor\Mapper\TypeTreeMapper;
Expand Down Expand Up @@ -92,8 +89,6 @@ public function __construct(Settings $settings)
$this->get(RootNodeBuilder::class)
),

ShellVisitor::class => fn () => new AttributeShellVisitor(),

RootNodeBuilder::class => fn () => new RootNodeBuilder(
$this->get(NodeBuilder::class)
),
Expand Down Expand Up @@ -149,7 +144,6 @@ public function __construct(Settings $settings)
}

$builder = new StrictNodeBuilder($builder, $settings->allowPermissiveTypes, $settings->enableFlexibleCasting);
$builder = new ShellVisitorNodeBuilder($builder, $this->get(ShellVisitor::class));

return new ErrorCatcherNodeBuilder($builder, $settings->exceptionFilter);
},
Expand Down
32 changes: 0 additions & 32 deletions src/Mapper/Tree/Builder/ShellVisitorNodeBuilder.php

This file was deleted.

22 changes: 0 additions & 22 deletions src/Mapper/Tree/Visitor/AttributeShellVisitor.php

This file was deleted.

13 changes: 0 additions & 13 deletions src/Mapper/Tree/Visitor/ShellVisitor.php

This file was deleted.

33 changes: 0 additions & 33 deletions tests/Fake/Mapper/Tree/Visitor/FakeShellVisitor.php

This file was deleted.

This file was deleted.

59 changes: 0 additions & 59 deletions tests/Integration/Mapping/Attribute/ShellVisitorMappingTest.php

This file was deleted.

0 comments on commit 8a7486a

Please sign in to comment.