-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Shift Internal Scrollbar to Root of Page #7
Comments
There shouldnt be a second scroll bar. So Im a bit confused. Can you post a screenshot and tell me what browser you are using? |
If it's a plava to deal with, maybe you could let me know what block the scrollbar is in (file and line number) and I'll make it a learning experience : ). I'm a DevOps engineer with no python chops |
So i have good news and bad news. Good news, I now understand what youre asking for Lines 2-4: Lines 2 to 4 in d0e3d6b
Lines 31-37: Lines 31 to 37 in d0e3d6b
However, I dont suggest you do that. I would suggest you create a .gradio-container > .flex > div.mx-auto.container {
display: block;
}
#tab_modelpreview_xd_interface > div {
position: relative;
top: unset;
bottom: unset;
right: unset;
left: unset;
} Otherwise it'll cause issues if you do a git pull. But I also dont know what you got going on with your forked code so, ill leave that up to you. Unfortunately (this might not apply to you) some more bad news is that doing this will pretty much break the ability to use HTML preview files. Because they are rendered in iframes the html doesn't know what height to set the div at, which is why I changed the UI to use flex layouts instead of block. This allowed me to set the area for the iframe to be everything south of the tab bar... but I didnt realize on wide screens like yours... or where you have multiple rows of tabs... that space gets pretty cramped. So if you do make this change you may also want to add some CSS to set the height of the iframes to something reasonable like 800px. There will be a second scroll bar that is rendered inside the iframe but there is nothing you can do about it. Unless you set the height of the iframe to a value which is greater than what the contents need... but... there isn't really a good way to handle that and keep it responsive. I did some thinking today but couldn't get to a solution that felt good. So ill do some more thinking and maybe figure something out. But for now, if you don't use HTML preview pages, I would add that CSS to your Example of hard coding the iframe height to a fixed value so that HTML preview files are still somewhat usable: #tab_modelpreview_xd_interface iframe {
height: 800px;
} |
Excellent solution to show full cards - mardown docs render at the bottom of the page too. So I'm stoked I added this to my user.css file .gradio-container > .flex > div.mx-auto.container {
display: block;
}
#tab_modelpreview_xd_interface > div {
position: relative;
top: unset;
bottom: unset;
right: unset;
left: unset;
} Pages render thusly: |
If you add a sponsor link happy to send a small one time donation for your help @CurtisDS |
Thank you for your offer. I've set up a sponsor link for Patreon. If you are interested in making a one-time donation, after you become a patron you will have to edit your pledge and cancel the automatic renewal to avoid being charged every month. A tad annoying but it was the easiest way for me to set something up. Thanks again for your support. |
done. sorry it's small, but I'm not employed right now, but still wanted to recognise your time |
I've gone and done the same, thanks for looking into our requests. |
Thank you for the support. I was not expecting it, but I do appreciate it |
Very cool! Nice work |
Hi there. Firstly, this extension is a personal favourite and is a fantastic way to track and keep assets organised with docs attached. Well done
I have forked this to allow me to restyle the cards to match the extra network styling and some extra tidbits. The item currently out of my skill scope is I'd like to remove the scroll bar. I find it a hindrance to viewing when there is a handful of images and docs
Cheers, again fantastic. I hope you keep this alive
The text was updated successfully, but these errors were encountered: