cuprated: add constants & statics modules
#301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-dependency
hinto-janai
commented
Sep 27, 2024
binaries/cuprated/src/statics.rs
Outdated
Comment on lines
8
to
41
| /// Define all the `static`s that should be always be initialized early on. | ||
| /// | ||
| /// This wraps all `static`s inside a `LazyLock` and generates | ||
| /// a [`init_lazylock_statics`] function that must/should be | ||
| /// used by `main()` early on. | ||
| macro_rules! define_init_lazylock_statics { | ||
| ($( | ||
| $( #[$attr:meta] )* | ||
| $name:ident: $t:ty = $init_fn:expr; | ||
| )*) => { | ||
| /// Initialize global static `LazyLock` data. | ||
| pub fn init_lazylock_statics() { | ||
| $( | ||
| LazyLock::force(&$name); | ||
| )* | ||
| } | ||
|
|
||
| $( | ||
| $(#[$attr])* | ||
| pub static $name: LazyLock<$t> = LazyLock::new(|| $init_fn); | ||
| )* | ||
| }; | ||
| } | ||
|
|
||
| define_init_lazylock_statics! { | ||
| /// The start time of `cuprated`. | ||
| START_INSTANT: SystemTime = SystemTime::now(); | ||
|
|
||
| /// Start time of `cuprated` as a UNIX timestamp. | ||
| START_INSTANT_UNIX: u64 = START_INSTANT | ||
| .duration_since(UNIX_EPOCH) | ||
| .expect("Failed to set `cuprated` startup time.") | ||
| .as_secs(); | ||
| } |
There was a problem hiding this comment.
I have little faith that people will manually update things so newly added statics that should be initialized before anything else go in this macro, which will generate a function that initializes everything.
There was a problem hiding this comment.
(people including us in the far future btw)
Comment on lines
22
to
+24
| fn main() { | ||
| // Initialize global static `LazyLock` data. | ||
| statics::init_lazylock_statics(); |
There was a problem hiding this comment.
The statics get initialized here.
We could add this to a broader init_everything() later that setups up logging as well.
Boog900
requested changes
Sep 27, 2024
Comment on lines
22
to
+24
| fn main() { | ||
| // Initialize global static `LazyLock` data. | ||
| statics::init_lazylock_statics(); |
binaries/cuprated/src/statics.rs
Outdated
Comment on lines
20
to
24
| $( | ||
| LazyLock::force(&$name); | ||
| )* | ||
| } | ||
|
|
There was a problem hiding this comment.
tabs here should be changed to spaces
Boog900
approved these changes
Sep 28, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a
constantsandstaticsmodule tocuprated.constantscontains general constants used bycuprated, currently it contains version strings roughly equivalent toversion.hstaticscontains globalstaticdata used throughoutcupratedSome data (e.g.
const DEBUG: bool) will be available incuprate_constantsso it isn't defined inconstants.Why
statics::START_INSTANT_UNIXis needed by RPC forget_block-> start_timeconstants::VERSION_BUILDis needed by RPC forget_block-> version