Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #12] Added pagination to watchlist, alarm- and device-list. #13

Merged
merged 10 commits into from
Dec 19, 2024
Merged

[Fix #12] Added pagination to watchlist, alarm- and device-list. #13

merged 10 commits into from
Dec 19, 2024

Conversation

joerghartmann
Copy link
Collaborator

@joerghartmann joerghartmann commented Dec 10, 2024 •
edited
Loading

  • Implementation is based on tableView(_ tableView: UITableView, prefetchRowsAt indexPaths: [IndexPath])
  • This message will cause a reload of the list by requesting current page + 1
  • Afterwards affected index paths are calculated and the table view refreshed
  • Alarms are stored as pages: [Int: Page] to preserve order

What's missing:

  • update indication on the list item itself, it shows empty strings for now, prob. a loading indicator is wanted?
  • support pagination within AlarmListViewController

joerghartmann and others added 2 commits December 10, 2024 16:16
@joerghartmann
[Fix #12] Updated SubscribedAlarmsViewController to load more than 50…
5151fd2 
… Alarms.
@joerghartmann
[Fix #10] Fixed an issue showing only up to 100 alarms. Reason is tha…
ac9b9a7 
…t the core implementation has 100 as hard maximum for the count operation. (#11)

(cherry picked from commit 191c3d7)
@joerghartmann joerghartmann changed the title [Fix #12] Simple pagination support for the watchlist. [Fix #12] Added pagination to watchlist, alarm- and device-list. Dec 17, 2024
@thomaswinkler
Copy link

@joerghartmann Can I merge the branch?

@joerghartmann joerghartmann merged commit 7a96e6f into main Dec 19, 2024
1 check failed
@joerghartmann joerghartmann deleted the feature/#12 branch December 19, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaswinkler thomaswinkler thomaswinkler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joerghartmann @thomaswinkler