Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Helper script #967

Open
wants to merge 52 commits into
base: development
Choose a base branch
from
Open

feat: Helper script #967

wants to merge 52 commits into from

Conversation

MrWeez
Copy link
Collaborator

@MrWeez MrWeez commented Jun 2, 2024 •
edited
Loading

Hi! πŸ‘‹

I present to your attention a script that was created to simplify routine actions such as βœ… installing dependencies and πŸ”„οΈ updating CPGG. It will be useful for simplifying actions for beginners, as well as for managing instance in a Docker container

This PR closes #955

TODO:

  • Installing dependencies
  • Updating panel
  • Argument mode (e.g. --install, --update)
  • Code refactor
  • Info & Help menu
  • UI refactor
  • Fix The repository 'https://packages.sury.org/php focal Release' does not have a Release file. on Ubuntu distros
  • Testing on Debian-based OS
  • Remove Easter egg
  • Remove unnecessary sudo

Known issues:
none

⚠️ WARNING FOR TESTERS: Do not forget to create a backup copy of important data, I cannot guarantee compatibility and correct operation of the script. If you have identified a problem, be sure to report it in the comments to the PR

@MrWeez MrWeez added Feature Adding a new feature, or substantial improvements on existing functionality Medium Priority Needs attention, not urgent labels Jun 2, 2024
@MrWeez MrWeez added this to the V0.10.0 milestone Jun 2, 2024
@MrWeez MrWeez self-assigned this Jun 2, 2024
@MrWeez MrWeez linked an issue Jun 2, 2024 that may be closed by this pull request
[Feature] Auto Update Script #955
Open
@IceToast IceToast changed the title ctrlhelper.sh script feat: Helper script Jun 4, 2024
MrWeez and others added 23 commits June 4, 2024 15:50
@MrWeez
feat: Specifying CPGG directory if it differs from the default one us…
cd1c4aa 
…ing CLI-GUI
@MrWeez
feat: Specifying CPGG directory using --cpgg-dir parameter
9344041
@MrWeez
feat: Saving and restoring terminal contents to execute a script in a…
46cf09a 
… "clean" terminal
@MrWeez
feat: Checking if the panel needs to be updated
bc972db
@MrWeez
feat: main menu and submenus template
72b4336
@MrWeez
fix: Π‘ase of letters in variables
5db0887
@MrWeez
refactor: logo_version now outputs only versions without logo
5f67a7f
@MrWeez
fix: make some variables readonly to prevent future errors
c3d9c09
@MrWeez
feat: CLI mode using argument
b8bee35
@MrWeez
fix: Check if argument "--cpgg-dir" not empty
3fd7a44
@MrWeez
fix: better error handling when using "--dir-cpgg" argument
b0908c1
@MrWeez
fix: readonly variables
eeaa5e7
@MrWeez
fix: displaying message about default directory when suvmit null value
4d9194a
@MrWeez
refactor: Improved checks when specifying a directory
31c841d
@MrWeez
refactor: comments and grammar improvements
08c0934
@MrWeez
fix: do not return negative values
f5f5cc1
@MrWeez
Merge branch 'development' into feature/script
2d521f7
@MrWeez
refactor: Fix Shellcheck warnings (SC2004)
64eb268
@MrWeez
fix: Change return codes to correct ones
08f5380
@MrWeez
refactor: Added and corrected comments and code optimization
a1d2377
@MrWeez
fix: --cpgg-dir argument returned an error even if it was specified
33eb066
@MrWeez
refactor: better error message
68b91d9
@MrWeez
feat: Install script dependencies on first script run
796f8f0
@MrWeez
Copy link
Collaborator Author

MrWeez commented Aug 3, 2024 •
edited
Loading

Issue on Ubuntu 20.04 when installing dependencies The repository 'https://packages.sury.org/php focal Release' does not have a Release file. This part of the code needs to be changed

The error is also present on Ubuntu 24.04, but the installation is completed successfully because the php repository is preinstalled in the system

@MrWeez
Copy link
Collaborator Author

MrWeez commented Aug 3, 2024

All script issues have been fixed, all checks have been passed. Another 1-2 people's feedback is needed, and it will be possible to merge PR into dev branch

@MrWeez MrWeez requested a review from S0ly August 3, 2024 23:27
@MrWeez MrWeez marked this pull request as ready for review August 3, 2024 23:27
S0ly
S0ly requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@S0ly S0ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gave some change on discord, waiting on feedback :)

@MrWeez MrWeez marked this pull request as draft August 8, 2024 13:56
@S0ly S0ly modified the milestones: V1.0, V1.1 Nov 11, 2024
@S0ly S0ly modified the milestones: V1.1, V1.0 Nov 12, 2024
@MrWeez MrWeez modified the milestones: V1.0, V1.1 Nov 24, 2024
@S0ly S0ly added the Inactive No activity since a long time label Dec 21, 2024
@S0ly
Copy link
Member

S0ly commented Dec 21, 2024

@MrWeez what you want to do of this branch ?

@MrWeez
Copy link
Collaborator Author

MrWeez commented Dec 21, 2024

@MrWeez what you want to do of this branch ?

I'll fix a couple of things soon, and release it under version 0.1.0, and completely refactor it in the future.

@MrWeez MrWeez marked this pull request as ready for review January 2, 2025 01:06
@MrWeez MrWeez requested a review from S0ly January 2, 2025 01:06
@MrWeez MrWeez removed the Inactive No activity since a long time label Jan 2, 2025
@MrWeez
Copy link
Collaborator Author

MrWeez commented Jan 12, 2025

@S0ly PR is already ready, it's just waiting for a review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S0ly S0ly Awaiting requested review from S0ly

Assignees

@MrWeez MrWeez

Labels
Feature Adding a new feature, or substantial improvements on existing functionality Medium Priority Needs attention, not urgent
Projects
None yet
Milestone
V1.1
Development

Successfully merging this pull request may close these issues.

[Feature] Auto Update Script
3 participants
@MrWeez @S0ly @1day2die