feat(js-storefrontaware-utils): Enforce empty crystallize secrets

CrystallizeAPI · Oct 4, 2022 · 28f133c · 28f133c
1 parent 2e430c4
commit 28f133c
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
     "name": "@crystallize/js-storefrontaware-utils",
     "license": "MIT",
-    "version": "0.2.0",
+    "version": "0.2.1",
     "author": "Crystallize <[email protected]> (https://crystallize.com)",
     "contributors": [
         "Sébastien Morel <[email protected]>"

diff --git a/src/adapters/filesystem.server.ts b/src/adapters/filesystem.server.ts
@@ -5,7 +5,18 @@ export const createFilesystemAdapter = (filename: string): TStoreFrontAdapter =>
     return {
         config: async (withSecrets: boolean): Promise<TStoreFrontConfig> => {
             const data = await fs.readFile(filename, { encoding: 'utf8' });
-            return JSON.parse(data);
+            const unfilteredSecrets = JSON.parse(data);
+            if (withSecrets) {
+                return unfilteredSecrets;
+            }
+            return {
+                ...unfilteredSecrets,
+                configuration: {
+                    ...unfilteredSecrets.configuration,
+                    ACCESS_TOKEN_ID: '',
+                    ACCESS_TOKEN_SECRET: '',
+                },
+            };
         },
     };
 };
diff --git a/src/adapters/memory.server.ts b/src/adapters/memory.server.ts
@@ -2,6 +2,18 @@ import { TStoreFrontAdapter, TStoreFrontConfig } from '../types';
 
 export const createMemoryAdapter = (config: TStoreFrontConfig): TStoreFrontAdapter => {
     return {
-        config: async (withSecrets: boolean): Promise<TStoreFrontConfig> => config,
+        config: async (withSecrets: boolean): Promise<TStoreFrontConfig> => {
+            if (withSecrets) {
+                return config;
+            }
+            return {
+                ...config,
+                configuration: {
+                    ...config.configuration,
+                    ACCESS_TOKEN_ID: '',
+                    ACCESS_TOKEN_SECRET: '',
+                },
+            };
+        },
     };
 };