902 - remove jackson json dependency #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Substitute all usage of jackson mapper with circe * Fix tests to account for the slight changes in signatures * Adapt the dynamic Map of Any used in NodeOperator to write operations with a shapeless Record that provides dynamic behavior of statically known complex structures via type-level generic programming * remove unused code
ivanopagano
force-pushed
the
refactor/902-security-remove-jackson-json-dependency
branch
from
4fa2c05 to
22d477d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
vishakh
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #902 by removing
jackson-databinddependency from the project.All json handling is now done using Circe
Those parts of the code that required handling generic structures now make use of
shapelessRecord syntax to build statically known generic structures.For additional info, refer to this online guide, Chapter 5
Finally, the smoke tests are updated to work under the latest conseil assumptions, after the most recent changes.