Chore: upgrade postgres version on tests and local docker to 11.x #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix db tests with ordering based on encoding of strings * clean up the testcontainers setup
ivanopagano
requested review from
dorians,
vishakh,
piotrkosecki,
ba205 and
bhaskarkishore
dorians
approved these changes
Dec 30, 2019
| super.beforeEach() | ||
| Await.ready(dbHandler.run(truncateAll), 1.second) | ||
| () |
There was a problem hiding this comment.
Essentially yes, but it removes a warning about discarding non-unit values
piotrkosecki
reviewed
Jan 2, 2020
src/test/scala/tech/cryptonomic/conseil/tezos/TezosDatabaseOperationsTest.scala
Outdated
Show resolved
Hide resolved
* explicitly set (when possible) and verify the sorting of strings * avoid the alpine db image since it doesn't correctly use the en_US collation type
piotrkosecki
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #625
Since we've now switched to test-containers for db integration tests, we can now upgrade local docker definitions and the tests versions of postgres to
11.x, more in line with production.