597 - Lorre performance improvements #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng voting rolls, regenerated Tables
piotrkosecki
requested review from
dorians,
vishakh,
ivanopagano,
ba205,
anonymoussprocket and
bhaskarkishore
ivanopagano
reviewed
Nov 11, 2019
vishakh
approved these changes
Nov 14, 2019
ba205
approved these changes
Nov 15, 2019
anonymoussprocket
deleted the
feature/597-Lorre-performance-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #597
I was performing a lot of testing and most of the delays come from Tezos node calls and the complexity of the operations we need to make to fill some tables.
For example fetching baking/endorsing rights takes soo long because it fetches them for whole page of blocks(500) using batched fetchers - changing concurrency level does not seem to matter, and inserts don't take a lot of time.
Regarding removing foreign keys/indexes unfortunately that only helps when inserting and affects query performance -
accounts_checkpointis not being queried at all so I introduced change suggested by @ivanopagano in the ticket.Other possible change I've noticed is inserting voting rolls using single query instead of transactionally. That can improve performance a bit, but from what I've tested many times there was nothing to insert.
If anyone has any suggestions what else could be improved feel free to comment here or in the ticket #597.