Now accounting for string-encoded Hangul characters #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt string resemble source and simplified unit tests.
dorians
approved these changes
Mar 29, 2019
anonymoussprocket
added a commit
that referenced
this pull request
Mar 18, 2020
anonymoussprocket
added a commit
that referenced
this pull request
Mar 18, 2020
vishakh
pushed a commit
that referenced
this pull request
Mar 19, 2020
vishakh
pushed a commit
that referenced
this pull request
Mar 19, 2020
vishakh
pushed a commit
that referenced
this pull request
Mar 23, 2020
* - metadata fix for Arronax #304 * - metadata fix for Arronax #304 * - updated baker name data * - added proposal names * - removed proposals table * - removed proposals table * - value-maps updates * -value-maps updates * - special account name * - metadata update * - metadata update * - metadata update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty safe to say any string-encoded escaped character will cause trouble, with one or two backslashes. This PR relaxes the constraint around looking only for hex characters and also sanitizes double backslashes.