Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granada related fixes and updates. #1030

Merged
merged 4 commits into from
Sep 20, 2021

Conversation

piotrkosecki
Copy link
Contributor

@piotrkosecki piotrkosecki commented Aug 12, 2021

This PR contains bunch of fixes related to the Granada upgrade:

  1. Baking/endorsing rights update after main loop reaches the head(previously only estimated_time was updated)
  2. Explicitly using config setting for tracing calls and parsing.max-to-strict-bytes(responsible for recent errors with request too large) and adding reading those values from env variables
  3. Adding renamed field deposits to CycleBalance case class so we will avoid some warnings(and keeping the original one so we will be backward compatible)
  4. Adding env variables for logging - it seems that we already support logging initial connection to Tezos node, but it was hidden - I've added it explicitly. We could say that this PR also resolves Lorre does not log the initial connection attempt to Tezos #966

…e size length and added renamed deposits to CycleBalance
path-prefix: ${?CONSEIL_XTZ_NODE_PATH_PREFIX}

trace-calls: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us document this.

metadata-fetching-is-on: ${?CONSEIL_LORRE_BLOCK_RIGHTS_FETCHING_ENABLED}
fork-handling-is-on: false
fork-handling-is-on: ${?CONSEIL_LORRE_FORK_DETECTION_ENABLED}
fork-handling-is-on: ${?CONSEIL_LORRE_FORK_DETECTION_ENABLED}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental space

@@ -52,6 +52,7 @@ logging: {
# get extra info from the akka-streamed async calls to the node, if trace-calls is enabled on the node conf.
# change the level of the root logger handler accordingly to see the output (i.e. add outputLevel: "DEBUG")
name: "tech.cryptonomic.conseil.indexer.tezos.node-rpc.batch",
from-env: "LORRE_NODE_RPC_BATCH_LOG_LEVEL",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's document this.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vishakh vishakh merged commit 3fb5b4e into master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lorre does not log the initial connection attempt to Tezos
3 participants