Solving issue #1905: Aggregate Fights into a single txn to reduce gas…

[NindoK]

All Submissions

New Feature Submissions

Related to issues #1905

Notes

Please note, your code must pass all tests and lint checks before it can be merged.

PR Description

In this PR I propose a solution for aggregating all the fights into a single txn.

The solution require minor changes in the contract:

1. Change the function declaration in order to take in input arrays of data, instead of single values
2. Loop through each characters and perform fight
3. Keep track of the cumulated tokens
4. revert if needed or complete execution.

Instead in the Front End, I have readapted two old functions fightTarget in Combat.vue and doEncounterPayNative in index.ts, I have just renamed these functions with their plural form to remain consistent.

In both files I have changed that instead of the single values like characterId, targetId or fightMultiplier, now they are all arrays.

For now this PR solves only the fighting part, but not the UI. The UI should let the users select for each character their enemy and then with a button fight all of them at once.

With this change the transaction gas goes down from ~356k to ~230k.

I have made some small changes into the README.md file, since I had some troubles while setting up the environment.

Testing

The code has been tested multiple times, but I advise to check the math behind the offset, since I might not have understood correctly.

[Chriserus]

LGTM, also consulted with @bilbolPrime
Please resolve the conflicts

[NindoK]

LGTM, also consulted with @bilbolPrime Please resolve the conflicts

Awesome! Glad to hear it :D Just solved the conflicts.